Fix implicit construction of std::string from std::string_view

jschmidt-icinga · jschmidt-icinga · commit de2e69ef6298 · 2025-12-15T14:08:03.000+01:00
diff --git a/lib/perfdata/elasticsearchdatastreamwriter.cpp b/lib/perfdata/elasticsearchdatastreamwriter.cpp
@@ -664,7 +664,7 @@ Value ElasticsearchDatastreamWriter::TrySend(const Url::Ptr& url, String body)
 	}
 
 	/* Accept application/json with optional charset (any variant), case-insensitive. */
-	std::string ctLower = response[http::field::content_type];
+	auto ctLower = std::string{response[http::field::content_type]};
 	boost::trim(ctLower);
 	boost::to_lower(ctLower);
 	if (!(ctLower == "application/json" || ctLower == "application/json; charset=utf-8")) {

Original file line number	Diff line number	Diff line change
`@@ -664,7 +664,7 @@ Value ElasticsearchDatastreamWriter::TrySend(const Url::Ptr& url, String body)`
`664`	`664`	`}`
`665`	`665`
`666`	`666`	`/* Accept application/json with optional charset (any variant), case-insensitive. */`
`667`		`- std::string ctLower = response[http::field::content_type];`
	`667`	`+ auto ctLower = std::string{response[http::field::content_type]};`
`668`	`668`	`boost::trim(ctLower);`
`669`	`669`	`boost::to_lower(ctLower);`
`670`	`670`	`if (!(ctLower == "application/json" \|\| ctLower == "application/json; charset=utf-8")) {`