Description
When updating a harvesting client via the PUT endpoint /api/harvest/clients/{nickName}, the allowHarvestingMissingCVV field is not being retrieved from the JSON request body and therefore not persisted in the database.
Steps to Reproduce
- Create a harvesting client via the API or UI
- Attempt to update the client using PUT
/api/harvest/clients/{nickName} with allowHarvestingMissingCVV set to a different value
- Retrieve the client configuration and observe that
allowHarvestingMissingCVV has not been updated
Expected Behavior
The allowHarvestingMissingCVV value should be retrieved from the JSON request body and updated in the harvesting client configuration.
Actual Behavior
The allowHarvestingMissingCVV value is ignored during the PUT request. The field value remains unchanged.
Root Cause Analysis
In HarvestingClients.java, the modifyHarvestingClient() method does not extract the allowHarvestingMissingCVV value from the incoming JSON object, unlike other fields such as harvestUrl, archiveUrl, etc.
Version
Relevant Code
- File:
src/main/java/edu/harvard/iq/dataverse/api/HarvestingClients.java
- Method:
modifyHarvestingClient() (PUT handler)
Are you thinking about creating a pull request for this issue?
No fix is currently planned by the team.
Description
When updating a harvesting client via the PUT endpoint
/api/harvest/clients/{nickName}, theallowHarvestingMissingCVVfield is not being retrieved from the JSON request body and therefore not persisted in the database.Steps to Reproduce
/api/harvest/clients/{nickName}withallowHarvestingMissingCVVset to a different valueallowHarvestingMissingCVVhas not been updatedExpected Behavior
The
allowHarvestingMissingCVVvalue should be retrieved from the JSON request body and updated in the harvesting client configuration.Actual Behavior
The
allowHarvestingMissingCVVvalue is ignored during the PUT request. The field value remains unchanged.Root Cause Analysis
In
HarvestingClients.java, themodifyHarvestingClient()method does not extract theallowHarvestingMissingCVVvalue from the incoming JSON object, unlike other fields such asharvestUrl,archiveUrl, etc.Version
Relevant Code
src/main/java/edu/harvard/iq/dataverse/api/HarvestingClients.javamodifyHarvestingClient()(PUT handler)Are you thinking about creating a pull request for this issue?
No fix is currently planned by the team.