From ad1031fedcaf60813eb1c177e52db16f70a25eee Mon Sep 17 00:00:00 2001
From: Ahmed Hamouda <ahmed.hamouda@minervis.com>
Date: Mon, 26 Jan 2026 16:24:30 +0100
Subject: [PATCH] correct type hints and imports in Activities component

---
 .../Component/src/Activities/Activity.php     |  2 +-
 .../src/Activities/ObjectActivity.php         | 59 +++++++++++++++++++
 .../Component/src/Activities/Repository.php   |  4 +-
 .../src/Activities/StaticRepository.php       |  2 +
 .../ILIAS/Setup/src/Activities/GetStatus.php  |  4 +-
 5 files changed, 67 insertions(+), 4 deletions(-)
 create mode 100644 components/ILIAS/Component/src/Activities/ObjectActivity.php

diff --git a/components/ILIAS/Component/src/Activities/Activity.php b/components/ILIAS/Component/src/Activities/Activity.php
index 1baf108fd747..497b72e17232 100644
--- a/components/ILIAS/Component/src/Activities/Activity.php
+++ b/components/ILIAS/Component/src/Activities/Activity.php
@@ -21,10 +21,10 @@
 namespace ILIAS\Component\Activities;
 
 use ILIAS\Component\Dependencies\Name;
-use ILIAS\UI\Component\Input\Control\Form\FormInput;
 use ILIAS\Data\Result;
 use ILIAS\Data\Text;
 use ILIAS\Data\Description;
+use ILIAS\UI\Component\Input\Container\Form\FormInput;
 
 /**
  * An Activity is an action on the domain layer action of a component.
diff --git a/components/ILIAS/Component/src/Activities/ObjectActivity.php b/components/ILIAS/Component/src/Activities/ObjectActivity.php
new file mode 100644
index 000000000000..26a4fcbc474e
--- /dev/null
+++ b/components/ILIAS/Component/src/Activities/ObjectActivity.php
@@ -0,0 +1,59 @@
+<?php
+
+/**
+ * This file is part of ILIAS, a powerful learning management system
+ * published by ILIAS open source e-Learning e.V.
+ *
+ * ILIAS is licensed with the GPL-3.0,
+ * see https://www.gnu.org/licenses/gpl-3.0.en.html
+ * You should have received a copy of said license along with the
+ * source code, too.
+ *
+ * If this is not the case or you just want to try ILIAS, you'll find
+ * us at:
+ * https://www.ilias.de
+ * https://github.com/ILIAS-eLearning
+ *
+ *********************************************************************/
+
+declare(strict_types=1);
+
+namespace ILIAS\Component\Activities;
+
+use ILIAS\UI\Component\Input\Container\Form\FormInput;
+use ILIAS\UI\Component\Input\Input;
+
+/**
+ * An Activity that refers to a certain object in the system. This also is a
+ * generic interface but a subset of inputs is fixed.
+ *
+ * This does not necessarily need to refer to an ilObject, but can also be used
+ * to refer to any objects internal to a given component, such as questions,
+ * memberships or certain results.
+ */
+interface ObjectActivity extends Activity
+{
+    /**
+     * @inheritdoc
+     *
+     * For an ObjectActivity, this needs to return an input with one field named
+     * "id" that can accept a string value.
+     */
+    public function getInputDescription(): FormInput;
+
+    /**
+     * Works just like `getInputDescription` but checks if that description
+     * matches the spec.
+     *
+     * @throws \LogicException if there is no "id" field in the Input.
+     */
+    public function getCheckedInputDescription(): Input;
+
+    /**
+     * To allow consumers to build an understanding of internal object structure of
+     * a component, an ObjectActivity needs to tell a "type" of object it touches.
+     *
+     * The type should be a short alphanumeric string.
+     */
+    public function getTargetType(): string;
+}
diff --git a/components/ILIAS/Component/src/Activities/Repository.php b/components/ILIAS/Component/src/Activities/Repository.php
index 21df8da1b4fe..05cbb5b9313f 100644
--- a/components/ILIAS/Component/src/Activities/Repository.php
+++ b/components/ILIAS/Component/src/Activities/Repository.php
@@ -20,13 +20,15 @@
 
 namespace ILIAS\Component\Activities;
 
+use ILIAS\Data\Range;
+
 interface Repository
 {
     /**
      * Get all activities where the name matches the provided regexp.
      *
      * @param string $name_matcher as preg_match can understand
-     * @return Iterator<string, Activity> where keys are the name
+     * @return \Iterator<string, Activity> where keys are the name
      */
     public function getActivitiesByName(string $name_matcher, ?ActivityType $type = null, ?Range $range = null): \Iterator;
 }
diff --git a/components/ILIAS/Component/src/Activities/StaticRepository.php b/components/ILIAS/Component/src/Activities/StaticRepository.php
index 4e094fc7798f..ec08aa6e62e7 100644
--- a/components/ILIAS/Component/src/Activities/StaticRepository.php
+++ b/components/ILIAS/Component/src/Activities/StaticRepository.php
@@ -20,6 +20,8 @@
 
 namespace ILIAS\Component\Activities;
 
+use ILIAS\Data\Range;
+
 class StaticRepository implements Repository
 {
     protected array $activities = [];
diff --git a/components/ILIAS/Setup/src/Activities/GetStatus.php b/components/ILIAS/Setup/src/Activities/GetStatus.php
index 6c6728d064d1..840ae753b77d 100644
--- a/components/ILIAS/Setup/src/Activities/GetStatus.php
+++ b/components/ILIAS/Setup/src/Activities/GetStatus.php
@@ -21,9 +21,9 @@
 namespace ILIAS\Setup\Activities;
 
 use ILIAS\Component\Dependencies\Name;
-use ILIAS\UI\Component\Input\Control\Form\FormInput;
 use ILIAS\Data\Result;
 use ILIAS\Data\Text;
+use ILIAS\UI\Component\Input\Container\Form\FormInput;
 
 /**
  * This is a stub...
@@ -34,7 +34,7 @@ public function getDescription(): Text\SimpleDocumentMarkdown
     {
     }
 
-    public function getInputDescription(): \ILIAS\UI\Component\Input\Control\Form\FormInput
+    public function getInputDescription(): FormInput
     {
     }