From 4ce3d5d9f2b5d53796605e9c87e773cc9fbfcee5 Mon Sep 17 00:00:00 2001
From: Fabian Helfer <fhelfer@databay.de>
Date: Mon, 26 Jan 2026 15:41:13 +0100
Subject: [PATCH 1/3] [Fix] #004698 UI: Add role for glyphs without href

---
 .../Implementation/Component/Symbol/Glyph/Renderer.php | 10 ++++++++++
 .../default/Symbol/tpl.glyph.context_btn.html          |  2 +-
 .../templates/default/Symbol/tpl.glyph.standard.html   |  2 +-
 3 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/components/ILIAS/UI/src/Implementation/Component/Symbol/Glyph/Renderer.php b/components/ILIAS/UI/src/Implementation/Component/Symbol/Glyph/Renderer.php
index 83195849394c..9f0e3b35147e 100755
--- a/components/ILIAS/UI/src/Implementation/Component/Symbol/Glyph/Renderer.php
+++ b/components/ILIAS/UI/src/Implementation/Component/Symbol/Glyph/Renderer.php
@@ -67,6 +67,16 @@ public function render(Component\Component $component, RendererInterface $defaul
             $tpl->parseCurrentBlock();
         }
 
+        $has_action = $component->isActive() && ($component->getAction() !== '');
+        $is_clickable = $component->isTabbable() || ($component instanceof Component\Triggerer && count($component->getTriggeredSignals()) > 0);
+
+        if (!$has_action) {
+            $role = $is_clickable ? 'button' : 'img';
+            $tpl->setCurrentBlock("with_role");
+            $tpl->setVariable("ROLE", $role);
+            $tpl->parseCurrentBlock();
+        }
+
         $tpl = $this->renderLabel($component, $tpl);
 
         $id = $this->bindJavaScript($component);
diff --git a/components/ILIAS/UI/src/templates/default/Symbol/tpl.glyph.context_btn.html b/components/ILIAS/UI/src/templates/default/Symbol/tpl.glyph.context_btn.html
index c36bf807c5c1..fbde6217c88f 100755
--- a/components/ILIAS/UI/src/templates/default/Symbol/tpl.glyph.context_btn.html
+++ b/components/ILIAS/UI/src/templates/default/Symbol/tpl.glyph.context_btn.html
@@ -1,3 +1,3 @@
-<span class="glyph<!-- BEGIN highlighted --> highlighted<!-- END highlighted --><!-- BEGIN disabled --> disabled<!-- END disabled -->" <!-- BEGIN with_aria_disabled --> aria-disabled="{ARIA_DISABLED}"<!-- END with_aria_disabled --><!-- BEGIN aria_label --> aria-label="{LABEL}"<!-- END aria_label --> role="img"<!-- BEGIN with_id --> id="{ID}"<!-- END with_id -->>
+<span class="glyph<!-- BEGIN highlighted --> highlighted<!-- END highlighted --><!-- BEGIN disabled --> disabled<!-- END disabled -->" <!-- BEGIN with_aria_disabled --> aria-disabled="{ARIA_DISABLED}"<!-- END with_aria_disabled --><!-- BEGIN aria_label --> aria-label="{LABEL}"<!-- END aria_label --><!-- BEGIN with_role --> role="{ROLE}"<!-- END with_role --><!-- BEGIN with_id --> id="{ID}"<!-- END with_id -->>
 {GLYPH}
 </span>
diff --git a/components/ILIAS/UI/src/templates/default/Symbol/tpl.glyph.standard.html b/components/ILIAS/UI/src/templates/default/Symbol/tpl.glyph.standard.html
index 7da77fabbc12..607c04cf017a 100755
--- a/components/ILIAS/UI/src/templates/default/Symbol/tpl.glyph.standard.html
+++ b/components/ILIAS/UI/src/templates/default/Symbol/tpl.glyph.standard.html
@@ -1,3 +1,3 @@
-<a <!-- BEGIN tabbable -->tabindex="0" <!-- END tabbable -->class="glyph<!-- BEGIN highlighted --> highlighted<!-- END highlighted --><!-- BEGIN disabled --> disabled<!-- END disabled -->"<!-- BEGIN with_action --> href="{ACTION}"<!-- END with_action --> aria-label="{LABEL}"<!-- BEGIN with_aria_disabled --> aria-disabled="{ARIA_DISABLED}"<!-- END with_aria_disabled --><!-- BEGIN with_id --> id="{ID}"<!-- END with_id -->>
+<a<!-- BEGIN tabbable --> tabindex="0"<!-- END tabbable --> class="glyph<!-- BEGIN highlighted --> highlighted<!-- END highlighted --><!-- BEGIN disabled --> disabled<!-- END disabled -->"<!-- BEGIN with_action --> href="{ACTION}"<!-- END with_action --> aria-label="{LABEL}"<!-- BEGIN with_aria_disabled --> aria-disabled="{ARIA_DISABLED}"<!-- END with_aria_disabled --><!-- BEGIN with_role --> role="{ROLE}"<!-- END with_role --><!-- BEGIN with_id --> id="{ID}"<!-- END with_id -->>
 {GLYPH}
 </a>

From c486a9e4aaa4020ebf982be1638fb0aa6ab2c8b0 Mon Sep 17 00:00:00 2001
From: Fabian Helfer <fhelfer@databay.de>
Date: Tue, 27 Jan 2026 14:33:18 +0100
Subject: [PATCH 2/3] [Fix] #004698 UI: Fix Unit Tests

---
 .../Symbol/Glyph/ButtonContextRenderer.php    |  5 ++++
 .../Component/Symbol/Glyph/Renderer.php       | 26 ++++++++++++-------
 .../default/Symbol/tpl.glyph.context_btn.html |  2 +-
 .../UI/tests/Component/Entity/EntityTest.php  |  6 ++---
 .../Container/Filter/StandardFilterTest.php   | 16 ++++++------
 .../Component/Symbol/Glyph/GlyphTest.php      | 10 +++----
 6 files changed, 38 insertions(+), 27 deletions(-)

diff --git a/components/ILIAS/UI/src/Implementation/Component/Symbol/Glyph/ButtonContextRenderer.php b/components/ILIAS/UI/src/Implementation/Component/Symbol/Glyph/ButtonContextRenderer.php
index 53a023c61f8f..42a6191e52d9 100755
--- a/components/ILIAS/UI/src/Implementation/Component/Symbol/Glyph/ButtonContextRenderer.php
+++ b/components/ILIAS/UI/src/Implementation/Component/Symbol/Glyph/ButtonContextRenderer.php
@@ -53,4 +53,9 @@ protected function renderLabel(Component\Component $component, Template $tpl): T
 
         return $tpl;
     }
+
+    public function renderRole(Component\Component $component, Template $tpl): Template
+    {
+        return $tpl;
+    }
 }
diff --git a/components/ILIAS/UI/src/Implementation/Component/Symbol/Glyph/Renderer.php b/components/ILIAS/UI/src/Implementation/Component/Symbol/Glyph/Renderer.php
index 9f0e3b35147e..fba5201b35b2 100755
--- a/components/ILIAS/UI/src/Implementation/Component/Symbol/Glyph/Renderer.php
+++ b/components/ILIAS/UI/src/Implementation/Component/Symbol/Glyph/Renderer.php
@@ -67,16 +67,7 @@ public function render(Component\Component $component, RendererInterface $defaul
             $tpl->parseCurrentBlock();
         }
 
-        $has_action = $component->isActive() && ($component->getAction() !== '');
-        $is_clickable = $component->isTabbable() || ($component instanceof Component\Triggerer && count($component->getTriggeredSignals()) > 0);
-
-        if (!$has_action) {
-            $role = $is_clickable ? 'button' : 'img';
-            $tpl->setCurrentBlock("with_role");
-            $tpl->setVariable("ROLE", $role);
-            $tpl->parseCurrentBlock();
-        }
-
+        $tpl= $this->renderRole($component, $tpl);
         $tpl = $this->renderLabel($component, $tpl);
 
         $id = $this->bindJavaScript($component);
@@ -108,6 +99,21 @@ protected function renderAction(Component\Component $component, Template $tpl):
         return $tpl;
     }
 
+    public function renderRole(Component\Component $component, Template $tpl): Template
+    {
+        $has_action = $component->isActive() && ($component->getAction() !== null);
+        $is_clickable = $component->isTabbable() || ($component instanceof Component\Triggerer && count($component->getTriggeredSignals()) > 0);
+
+        if (!$has_action) {
+            $role = $is_clickable ? 'button' : 'img';
+            $tpl->setCurrentBlock("with_role");
+            $tpl->setVariable("ROLE", $role);
+            $tpl->parseCurrentBlock();
+        }
+
+        return $tpl;
+    }
+
     protected function getInnerGlyphHTML(Component\Component $component, RendererInterface $default_renderer): string
     {
         $tpl = $this->getTemplate('tpl.glyph.html', true, true);
diff --git a/components/ILIAS/UI/src/templates/default/Symbol/tpl.glyph.context_btn.html b/components/ILIAS/UI/src/templates/default/Symbol/tpl.glyph.context_btn.html
index fbde6217c88f..c36bf807c5c1 100755
--- a/components/ILIAS/UI/src/templates/default/Symbol/tpl.glyph.context_btn.html
+++ b/components/ILIAS/UI/src/templates/default/Symbol/tpl.glyph.context_btn.html
@@ -1,3 +1,3 @@
-<span class="glyph<!-- BEGIN highlighted --> highlighted<!-- END highlighted --><!-- BEGIN disabled --> disabled<!-- END disabled -->" <!-- BEGIN with_aria_disabled --> aria-disabled="{ARIA_DISABLED}"<!-- END with_aria_disabled --><!-- BEGIN aria_label --> aria-label="{LABEL}"<!-- END aria_label --><!-- BEGIN with_role --> role="{ROLE}"<!-- END with_role --><!-- BEGIN with_id --> id="{ID}"<!-- END with_id -->>
+<span class="glyph<!-- BEGIN highlighted --> highlighted<!-- END highlighted --><!-- BEGIN disabled --> disabled<!-- END disabled -->" <!-- BEGIN with_aria_disabled --> aria-disabled="{ARIA_DISABLED}"<!-- END with_aria_disabled --><!-- BEGIN aria_label --> aria-label="{LABEL}"<!-- END aria_label --> role="img"<!-- BEGIN with_id --> id="{ID}"<!-- END with_id -->>
 {GLYPH}
 </span>
diff --git a/components/ILIAS/UI/tests/Component/Entity/EntityTest.php b/components/ILIAS/UI/tests/Component/Entity/EntityTest.php
index 0a2f36d9088e..a58dd004c0c8 100755
--- a/components/ILIAS/UI/tests/Component/Entity/EntityTest.php
+++ b/components/ILIAS/UI/tests/Component/Entity/EntityTest.php
@@ -161,11 +161,11 @@ public function testEntityRendering(): void
     <div class="c-entity __availability">a</div>
     <div class="c-entity __details">d</div>
     <div class="c-entity __reactions">
-        <a class="glyph" aria-label="some glyph"><span class="glyphicon il-glyphicon-laugh" aria-hidden="true"></span></a>
-        <a class="glyph" aria-label="some glyph"><span class="glyphicon il-glyphicon-laugh" aria-hidden="true"></span></a>
+        <a class="glyph" aria-label="some glyph" role="img"><span class="glyphicon il-glyphicon-laugh" aria-hidden="true"></span></a>
+        <a class="glyph" aria-label="some glyph" role="img"><span class="glyphicon il-glyphicon-laugh" aria-hidden="true"></span></a>
     </div>
     <div class="c-entity __featured-reactions">
-        <a class="glyph" aria-label="some glyph"><span class="glyphicon il-glyphicon-laugh" aria-hidden="true"></span></a>
+        <a class="glyph" aria-label="some glyph" role="img"><span class="glyphicon il-glyphicon-laugh" aria-hidden="true"></span></a>
         <button class="btn btn-tag btn-tag-relevance-veryhigh" data-action="#" id="id_10">tag</button>
     </div>
 </div>
diff --git a/components/ILIAS/UI/tests/Component/Input/Container/Filter/StandardFilterTest.php b/components/ILIAS/UI/tests/Component/Input/Container/Filter/StandardFilterTest.php
index 99f20a3d5fbc..a6c9dadc23f3 100755
--- a/components/ILIAS/UI/tests/Component/Input/Container/Filter/StandardFilterTest.php
+++ b/components/ILIAS/UI/tests/Component/Input/Container/Filter/StandardFilterTest.php
@@ -184,12 +184,12 @@ public function testRenderActivatedCollapsed(): void
                 <button type="button" aria-expanded="false" aria-controls="active_inputs_id_1 section_inputs_id_1" id="opener_id_1">
                     <span>
                         <span data-collapse-glyph-visibility="0">
-                            <a class="glyph" aria-label="collapse_content">
+                            <a class="glyph" aria-label="collapse_content" role="img">
                                 <span class="glyphicon glyphicon-triangle-bottom" aria-hidden="true"></span>
                             </a>
                         </span>
                         <span data-expand-glyph-visibility="1">
-                            <a class="glyph" aria-label="expand_content">
+                            <a class="glyph" aria-label="expand_content" role="img">
                                 <span class="glyphicon glyphicon-triangle-right" aria-hidden="true"></span>
                             </a>
                         </span> filter
@@ -322,12 +322,12 @@ public function testRenderDeactivatedCollapsed(): void
                 <button type="button" aria-expanded="false" aria-controls="active_inputs_id_1 section_inputs_id_1" id="opener_id_1">
                     <span>
                         <span data-collapse-glyph-visibility="0">
-                            <a class="glyph" aria-label="collapse_content">
+                            <a class="glyph" aria-label="collapse_content" role="img">
                                 <span class="glyphicon glyphicon-triangle-bottom" aria-hidden="true"></span>
                             </a>
                         </span>
                         <span data-expand-glyph-visibility="1">
-                            <a class="glyph" aria-label="expand_content">
+                            <a class="glyph" aria-label="expand_content" role="img">
                                 <span class="glyphicon glyphicon-triangle-right" aria-hidden="true"></span>
                             </a>
                         </span> filter
@@ -460,12 +460,12 @@ public function testRenderActivatedExpanded(): void
                 <button type="button" aria-expanded="true" aria-controls="active_inputs_id_1 section_inputs_id_1" id="opener_id_1">
                     <span>
                         <span data-collapse-glyph-visibility="1">
-                            <a class="glyph" aria-label="collapse_content">
+                            <a class="glyph" aria-label="collapse_content" role="img">
                                 <span class="glyphicon glyphicon-triangle-bottom" aria-hidden="true"></span>
                             </a>
                         </span>
                         <span data-expand-glyph-visibility="0">
-                            <a class="glyph" aria-label="expand_content">
+                            <a class="glyph" aria-label="expand_content" role="img">
                                 <span class="glyphicon glyphicon-triangle-right" aria-hidden="true"></span>
                             </a>
                         </span> filter
@@ -598,12 +598,12 @@ public function testRenderDeactivatedExpanded(): void
                 <button type="button" aria-expanded="true" aria-controls="active_inputs_id_1 section_inputs_id_1" id="opener_id_1">
                     <span>
                         <span data-collapse-glyph-visibility="1">
-                            <a class="glyph" aria-label="collapse_content">
+                            <a class="glyph" aria-label="collapse_content" role="img">
                                 <span class="glyphicon glyphicon-triangle-bottom" aria-hidden="true"></span>
                             </a>
                         </span>
                         <span data-expand-glyph-visibility="0">
-                            <a class="glyph" aria-label="expand_content">
+                            <a class="glyph" aria-label="expand_content" role="img">
                                 <span class="glyphicon glyphicon-triangle-right" aria-hidden="true"></span>
                             </a>
                         </span> filter
diff --git a/components/ILIAS/UI/tests/Component/Symbol/Glyph/GlyphTest.php b/components/ILIAS/UI/tests/Component/Symbol/Glyph/GlyphTest.php
index 8c43362d56d2..d7cd7040ca68 100755
--- a/components/ILIAS/UI/tests/Component/Symbol/Glyph/GlyphTest.php
+++ b/components/ILIAS/UI/tests/Component/Symbol/Glyph/GlyphTest.php
@@ -355,7 +355,7 @@ public function testRenderSimple(string $type): void
         $css_classes = self::$canonical_css_classes[$type];
         $aria_label = self::$aria_labels[$type];
 
-        $expected = '<a class="glyph" aria-label="' . $aria_label . '"><span class="' . $css_classes . '" aria-hidden="true"></span></a>';
+        $expected = '<a class="glyph" aria-label="' . $aria_label . '" role="img"><span class="' . $css_classes . '" aria-hidden="true"></span></a>';
         $this->assertEquals($expected, $html);
     }
 
@@ -372,7 +372,7 @@ public function testRenderWithUnavailableAction(string $type): void
         $aria_label = self::$aria_labels[$type];
 
         $expected = '
-        <a class="glyph disabled" aria-label="' . $aria_label . '" aria-disabled="true">
+        <a class="glyph disabled" aria-label="' . $aria_label . '" aria-disabled="true" role="img">
             <span class="' . $css_classes . '" aria-hidden="true"></span>
         </a>';
         $this->assertEquals($this->brutallyTrimHTML($expected), $this->brutallyTrimHTML($html));
@@ -392,7 +392,7 @@ public function testRenderWithCounter(string $type): void
         $aria_label = self::$aria_labels[G\Glyph::MAIL];
 
         $expected = '
-            <a class="glyph" aria-label="' . $aria_label . '">
+            <a class="glyph" aria-label="' . $aria_label . '" role="img">
                     <span class="' . $css_classes . '" aria-hidden="true"></span>
                     <span class="il-counter"><span class="badge badge-notify il-counter-' . $type . '">42</span></span>
                     <span class="il-counter-spacer">42</span>
@@ -413,7 +413,7 @@ public function testRenderWithTwoCounters(): void
 
         $css_classes = self::$canonical_css_classes[G\Glyph::MAIL];
         $aria_label = self::$aria_labels[G\Glyph::MAIL];
-        $expected = '<a class="glyph" aria-label="' . $aria_label . '">' .
+        $expected = '<a class="glyph" aria-label="' . $aria_label . '" role="img">' .
                     '<span class="' . $css_classes . '" aria-hidden="true"></span>' .
                     '<span class="il-counter"><span class="badge badge-notify il-counter-status">7</span></span>' .
                     '<span class="il-counter"><span class="badge badge-notify il-counter-novelty">42</span></span>' .
@@ -460,7 +460,7 @@ public function testRenderWithOnLoadCode(string $type): void
         $aria_label = self::$aria_labels[$type];
 
         $id = $ids[0];
-        $expected = '<a class="glyph" aria-label="' . $aria_label . '" id="' . $id . '"><span class="' . $css_classes . '" aria-hidden="true"></span></a>';
+        $expected = '<a class="glyph" aria-label="' . $aria_label . '" role="img" id="' . $id . '"><span class="' . $css_classes . '" aria-hidden="true"></span></a>';
         $this->assertEquals($expected, $html);
     }
 }

From 7ac113ae2eccba010f0fb0b6f2e0c266fc2783e7 Mon Sep 17 00:00:00 2001
From: Fabian Helfer <fhelfer@databay.de>
Date: Tue, 27 Jan 2026 14:41:25 +0100
Subject: [PATCH 3/3] [Fix] #004698 UI: CS Fixer

---
 .../Component/Symbol/Glyph/ButtonContextRenderer.php        | 6 +++---
 .../src/Implementation/Component/Symbol/Glyph/Renderer.php  | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/components/ILIAS/UI/src/Implementation/Component/Symbol/Glyph/ButtonContextRenderer.php b/components/ILIAS/UI/src/Implementation/Component/Symbol/Glyph/ButtonContextRenderer.php
index 42a6191e52d9..e3fbcbf3f97b 100755
--- a/components/ILIAS/UI/src/Implementation/Component/Symbol/Glyph/ButtonContextRenderer.php
+++ b/components/ILIAS/UI/src/Implementation/Component/Symbol/Glyph/ButtonContextRenderer.php
@@ -38,16 +38,16 @@ protected function renderAction(Component\Component $component, Template $tpl):
     protected function renderLabel(Component\Component $component, Template $tpl): Template
     {
         $aria_label = $component->getLabel();
-        if($aria_label != '') {
+        if ($aria_label != '') {
             $aria_label = $this->txt($aria_label);
         }
         foreach ($component->getCounters() as $counter) {
-            if($counter->getNumber() > 0) {
+            if ($counter->getNumber() > 0) {
                 $aria_label .= $this->txt("counter_" . $counter->getType()) . " " . $counter->getNumber() . "; ";
             }
         }
 
-        if($aria_label != "") {
+        if ($aria_label != "") {
             $tpl->setVariable("LABEL", $aria_label);
         }
 
diff --git a/components/ILIAS/UI/src/Implementation/Component/Symbol/Glyph/Renderer.php b/components/ILIAS/UI/src/Implementation/Component/Symbol/Glyph/Renderer.php
index fba5201b35b2..fb3db4be80ba 100755
--- a/components/ILIAS/UI/src/Implementation/Component/Symbol/Glyph/Renderer.php
+++ b/components/ILIAS/UI/src/Implementation/Component/Symbol/Glyph/Renderer.php
@@ -67,7 +67,7 @@ public function render(Component\Component $component, RendererInterface $defaul
             $tpl->parseCurrentBlock();
         }
 
-        $tpl= $this->renderRole($component, $tpl);
+        $tpl = $this->renderRole($component, $tpl);
         $tpl = $this->renderLabel($component, $tpl);
 
         $id = $this->bindJavaScript($component);