Optimize ilSessionStatistics raw data aggregation

Author: mBeym

components/ILIAS/Authentication/classes/class.ilSessionStatistics.php

@@ -246,25 +246,73 @@ public static function aggretateRaw(int $a_now): void
         }
 
         $slot = self::createNewAggregationSlot($a_now);
+        $prepared_statement = self::getAggregatedRawDataPreparedStatement();
+        $raw_data = [];
         while (is_array($slot)) {
-            self::aggregateRawHelper($slot[0], $slot[1]);
+            $raw_data[] = self::aggregateRawHelper($slot[0], $slot[1]);
             $slot = self::createNewAggregationSlot($a_now);
         }
 
+        if ($raw_data !== []) {
+            global $DIC;
+            $DIC->database()->executeMultiple($prepared_statement, $raw_data);
+        }
+
         // #12728
         self::deleteAggregatedRaw($a_now);
     }
 
+    protected static function getAggregatedRawDataPreparedStatement(): ilDBStatement
+    {
+        global $DIC;
+        return $DIC->database()->prepareManip(
+            "UPDATE usr_session_stats "
+            . "SET active_min = ?, "
+            . "active_max = ?, "
+            . "active_avg = ?, "
+            . "active_end = ?, "
+            . "opened = ?, "
+            . "closed_manual = ?, "
+            . "closed_expire = ?, "
+            . "closed_login = ?, "
+            . "closed_misc = ? "
+            . "WHERE slot_begin = ? AND slot_end = ?",
+            [
+                ilDBConstants::T_INTEGER,
+                ilDBConstants::T_INTEGER,
+                ilDBConstants::T_INTEGER,
+                ilDBConstants::T_INTEGER,
+                ilDBConstants::T_INTEGER,
+                ilDBConstants::T_INTEGER,
+                ilDBConstants::T_INTEGER,
+                ilDBConstants::T_INTEGER,
+                ilDBConstants::T_INTEGER,
+                ilDBConstants::T_INTEGER,
+                ilDBConstants::T_INTEGER
+            ]
+        );
+    }
+
     /**
      * Aggregate statistics data for one slot
-     *
+     * @return array{
+     *     active_min: int,
+     *     active_max: int,
+     *     active_avg: float|int,
+     *     active_end: int,
+     *     opened: int,
+     *     closed_manual: int,
+     *     closed_expire: int,
+     *     closed_login: int,
+     *     closed_misc: int,
+     *     slot_begin: int,
+     *     slot_end: int
+     * }
      */
-    public static function aggregateRawHelper(int $a_begin, int $a_end): void
+    public static function aggregateRawHelper(int $a_begin, int $a_end): array
     {
         global $DIC;
 
-        $ilDB = $DIC['ilDB'];
-
         // "relevant" closing types
         $separate_closed = [
             ilSession::SESSION_CLOSE_USER,
@@ -354,26 +402,19 @@ public static function aggregateRawHelper(int $a_begin, int $a_end): void
         }
         unset($events);
 
-        // save aggregated data
-        $fields = [
-            'active_min' => ['integer', $active_min],
-            'active_max' => ['integer', $active_max],
-            'active_avg' => ['integer', $active_avg],
-            'active_end' => ['integer', $active_end],
-            'opened' => ['integer', $opened_counter],
-            'closed_manual' => ['integer', (int) ($closed_counter[ilSession::SESSION_CLOSE_USER] ?? 0)],
-            'closed_expire' => ['integer', (int) ($closed_counter[ilSession::SESSION_CLOSE_EXPIRE] ?? 0)],
-            'closed_login' => ['integer', (int) ($closed_counter[ilSession::SESSION_CLOSE_LOGIN] ?? 0)],
-            'closed_misc' => ['integer', (int) ($closed_counter[0] ?? 0)],
+        return [
+            'active_min' => $active_min,
+            'active_max' => $active_max,
+            'active_avg' => $active_avg,
+            'active_end' => $active_end,
+            'opened' => $opened_counter,
+            'closed_manual' => (int) ($closed_counter[ilSession::SESSION_CLOSE_USER] ?? 0),
+            'closed_expire' => (int) ($closed_counter[ilSession::SESSION_CLOSE_EXPIRE] ?? 0),
+            'closed_login' => (int) ($closed_counter[ilSession::SESSION_CLOSE_LOGIN] ?? 0),
+            'closed_misc' => (int) ($closed_counter[0] ?? 0),
+            'slot_begin' => $a_begin,
+            'slot_end' => $a_end,
         ];
-        $ilDB->update(
-            'usr_session_stats',
-            $fields,
-            [
-                'slot_begin' => ['integer', $a_begin],
-                'slot_end' => ['integer', $a_end]
-            ]
-        );
     }
 
     /**