46276: Failed test: Begriff kopieren

Author: alex40724

components/ILIAS/MediaObjects/MediaObject/MediaObjectRepository.php

@@ -41,11 +41,15 @@ public function create(
         string $title,
         \ilMobStakeholder $stakeholder,
         int $from_mob_id = 0
-    ) : void {
+    ): void {
+        $rid = "";
         if ($from_mob_id > 0) {
             $from_rid = $this->getRidForMobId($from_mob_id);
-            $rid = $this->irss->cloneContainer($from_rid);
-        } else {
+            if ($from_rid !== "") {
+                $rid = $this->irss->cloneContainer($from_rid);
+            }
+        }
+        if ($rid === "") {
             $rid = $this->irss->createContainer(
                 $stakeholder,
                 "mob.zip"
@@ -57,7 +61,7 @@ public function create(
         ]);
     }
 
-    public function getById(int $id) : ?array
+    public function getById(int $id): ?array
     {
         $set = $this->db->queryF(
             'SELECT * FROM mob_data WHERE id = %s',
@@ -76,7 +80,7 @@ public function getById(int $id) : ?array
         return null;
     }
 
-    public function delete(int $id) : void
+    public function delete(int $id): void
     {
         $this->db->manipulateF(
             'DELETE FROM mob_data WHERE id = %s',
@@ -85,7 +89,7 @@ public function delete(int $id) : void
         );
     }
 
-    protected function getRidForMobId(int $mob_id) : string
+    protected function getRidForMobId(int $mob_id): string
     {
         $set = $this->db->queryF(
             "SELECT * FROM mob_data " .
@@ -99,7 +103,7 @@ protected function getRidForMobId(int $mob_id) : string
         return "";
     }
 
-    public function addFileFromLegacyUpload(int $mob_id, string $tmp_name, string $target_path = "") : void
+    public function addFileFromLegacyUpload(int $mob_id, string $tmp_name, string $target_path = ""): void
     {
         if ($rid = $this->getRidForMobId($mob_id)) {
             if ($target_path === "") {
@@ -117,7 +121,7 @@ public function addFileFromUpload(
         int $mob_id,
         UploadResult $result,
         string $path = "/"
-    ) : void {
+    ): void {
         if ($rid = $this->getRidForMobId($mob_id)) {
             $this->irss->importFileFromUploadResultToContainer(
                 $rid,
@@ -127,7 +131,7 @@ public function addFileFromUpload(
         }
     }
 
-    public function addFileFromLocal(int $mob_id, string $tmp_name, string $path) : void
+    public function addFileFromLocal(int $mob_id, string $tmp_name, string $path): void
     {
         if ($rid = $this->getRidForMobId($mob_id)) {
             $this->irss->addLocalFileToContainer(
@@ -138,7 +142,7 @@ public function addFileFromLocal(int $mob_id, string $tmp_name, string $path) :
         }
     }
 
-    public function addLocalDirectory(int $mob_id, string $dir) : void
+    public function addLocalDirectory(int $mob_id, string $dir): void
     {
         if ($rid = $this->getRidForMobId($mob_id)) {
             $this->irss->addDirectoryToContainer(
@@ -148,20 +152,20 @@ public function addLocalDirectory(int $mob_id, string $dir) : void
         }
     }
 
-    public function getLocalSrc(int $mob_id, string $location) : string
+    public function getLocalSrc(int $mob_id, string $location): string
     {
         return $this->irss->getContainerUri($this->getRidForMobId($mob_id), $location);
     }
 
-    public function hasLocalFile(int $mob_id, string $location) : bool
+    public function hasLocalFile(int $mob_id, string $location): bool
     {
         return $this->irss->hasContainerEntry($this->getRidForMobId($mob_id), $location);
     }
 
     public function getLocationStream(
         int $mob_id,
         string $location
-    ) : ZIPStream {
+    ): ZIPStream {
         return $this->irss->getStreamOfContainerEntry(
             $this->getRidForMobId($mob_id),
             $location
@@ -171,8 +175,7 @@ public function getLocationStream(
     public function getInfoOfEntry(
         int $mob_id,
         string $path
-    )
-    {
+    ) {
         return $this->irss->getContainerEntryInfo(
             $this->getRidForMobId($mob_id),
             $path
@@ -182,8 +185,7 @@ public function getInfoOfEntry(
     public function deliverEntry(
         int $mob_id,
         string $path
-    ) : void
-    {
+    ): void {
         $this->irss->deliverContainerEntry(
             $this->getRidForMobId($mob_id),
             $path
@@ -192,15 +194,15 @@ public function deliverEntry(
 
     public function getContainerPath(
         int $mob_id
-    ) : string {
+    ): string {
         return $this->irss->getResourcePath($this->getRidForMobId($mob_id));
     }
 
     public function addStream(
         int $mob_id,
         string $location,
         FileStream $stream
-    ) : void {
+    ): void {
         $this->irss->addStreamToContainer(
             $this->getRidForMobId($mob_id),
             $stream,
@@ -212,7 +214,7 @@ public function addString(
         int $mob_id,
         string $location,
         string $content
-    ) : void {
+    ): void {
         $this->irss->addStringToContainer(
             $this->getRidForMobId($mob_id),
             $content,
@@ -222,27 +224,27 @@ public function addString(
 
     public function getContainerResource(
         int $mob_id
-    ) : ?StorableResource {
+    ): ?StorableResource {
         return $this->irss->getResource($this->getRidForMobId($mob_id));
     }
 
     public function getContainerResourceId(
         int $mob_id
-    ) : ?ResourceIdentification {
+    ): ?ResourceIdentification {
         return $this->irss->getResourceIdForIdString($this->getRidForMobId($mob_id));
     }
 
     public function removeLocation(
         int $mob_id,
         string $location
-    ) : void {
+    ): void {
         $this->irss->removePathFromContainer($this->getRidForMobId($mob_id), $location);
     }
 
     public function getFilesOfPath(
         int $mob_id,
         string $dir_path
-    ) : array {
+    ): array {
         return $this->irss->getContainerEntriesOfPath(
             $this->getRidForMobId($mob_id),
             $dir_path