AIS-958 - Changes for GET Resources API#797
Open
prachikurade1 wants to merge 2 commits into
Open
Conversation
Signed-off-by: Prachi Kurade <prachi.kurade1@ibm.com>
mkumatag
requested changes
May 22, 2026
| response := ResourcesResponse{} | ||
|
|
||
| // Get Podman system info for CPU and memory | ||
| cpuInfo, memInfo, err := h.getPodmanSystemInfo() |
Member
There was a problem hiding this comment.
this call should be made to generic systemInfo call and then respective runtime call needs to be make, calling directly the podmansysteminfo here is not a good idea and this will break immediately when you run this api on openshift api
and for openshift implementation - you can return an empty response..
| totalCards, err := helpers.ListSpyreCards() | ||
| if err != nil { | ||
| logger.Errorf("Could not list Spyre cards: %v", err) | ||
| accelerators["ibm.com/spyre_pf"] = &AcceleratorInfo{ |
Member
There was a problem hiding this comment.
why you even want to include if no spyre cards found, ideally it should be an empty array in the accelerator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.