Extract common chatbot vars #760
Open
sats-23 wants to merge 2 commits into
Open
Conversation
Signed-off-by: Sathvik <Sathvik.S@ibm.com>
Signed-off-by: Sathvik <Sathvik.S@ibm.com>
Member
dharaneeshvrd
left a comment
dharaneeshvrd
left a comment
There was a problem hiding this comment.
Dont we need to bump chat ui version?
| # @description Search mode for similarity search. Options: "dense" (cosine similarity), "sparse" (BM25), "hybrid" (both). Default is "dense". | ||
| searchMode: "hybrid" | ||
| # @description Number of document chunks to retrieve from similarity search. Default is 10. | ||
| numChunksPostSearch: 10 |
Member
There was a problem hiding this comment.
this should be defined in similarity service
from chatbot we would be using numChunksPostReranker only once we start consuming similarity search endpoint part of chat completion endpoint.
currently numChunksPostSearch its defined in settings, lets use it from there till we replace it, no need to add it in manifest here
| value: "7000" | ||
| - name: CHATBOT_SEARCH_MODE | ||
| value: "{{ .Values.chatbot.searchMode }}" | ||
| - name: CHATBOT_NUM_CHUNKS_POST_SEARCH |
Member
There was a problem hiding this comment.
we should use NUM_CHUNKS_POST_RERANKER and that should be referred in chatbot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.