Skip to content

Commit 286d66e

Browse files
committed
one more rule
1 parent f01767b commit 286d66e

2 files changed

Lines changed: 25 additions & 29 deletions

File tree

app/designations/rules.py

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ def match(self, value: str) -> str | None:
3434
NameRule(
3535
name="CAT JHHMMSS.sss+DDMMSS.sss",
3636
pattern=re.compile(
37-
r"^([A-Za-z0-9]{2,5})J(\d{2})(\d{2})(\d{2}(?:\.\d+)?)([+-])(\d{2})(\d{2})(\d{2}(?:\.\d+)?)$",
37+
r"^([A-Za-z0-9]{2,6})J(\d{2})(\d{2})(\d{2}(?:\.\d+)?)([+-])(\d{2})(\d{2})(\d{2}(?:\.\d+)?)$",
3838
re.IGNORECASE,
3939
),
4040
replacement="",
@@ -61,6 +61,15 @@ def match(self, value: str) -> str | None:
6161
replacement="",
6262
replacer=lambda m: f"{m.group(1).upper()} J{m.group(2)}{m.group(3)}{m.group(4)}{m.group(5)}{m.group(6)}",
6363
),
64+
NameRule(
65+
name="CAT HHMM+DDMM",
66+
pattern=re.compile(
67+
r"^([A-Za-z0-9]{2,5})\s*(\d{2})(\d{2})([+-])(\d{2})(\d{2})$",
68+
re.IGNORECASE,
69+
),
70+
replacement="",
71+
replacer=lambda m: f"{m.group(1).upper()} {m.group(2)}{m.group(3)}{m.group(4)}{m.group(5)}{m.group(6)}",
72+
),
6473
NameRule(
6574
name="CAT J HHMM+DD",
6675
pattern=re.compile(
@@ -140,11 +149,6 @@ def match(self, value: str) -> str | None:
140149
),
141150
replacement="[{0}] J{1}{2}{3}",
142151
),
143-
NameRule(
144-
name="MAGE",
145-
pattern=re.compile(r"^MAGE\s*(\d{4})([+-])(\d{4})$", re.IGNORECASE),
146-
replacement="MAGE {0}{1}{2}",
147-
),
148152
NameRule(
149153
name="ISI96",
150154
pattern=re.compile(r"^ISI96_(\d{4})([+-])(\d{4})$", re.IGNORECASE),
@@ -259,14 +263,6 @@ def match(self, value: str) -> str | None:
259263
pattern=re.compile(r"^CNOC2_(\d+)\.(\d+)$", re.IGNORECASE),
260264
replacement="CNOC2_{0}.{1}",
261265
),
262-
NameRule(
263-
name="LAMOST",
264-
pattern=re.compile(
265-
r"^LAMOSTJ(\d{2})(\d{2})(\d{2}(?:\.\d+)?)([+-])(\d{2})(\d{2})(\d{2}(?:\.\d+)?)$",
266-
re.IGNORECASE,
267-
),
268-
replacement="LAMOST J{0}{1}{2}{3}{4}{5}{6}",
269-
),
270266
NameRule(
271267
name="2MFGC",
272268
pattern=re.compile(r"^2MFGC\s*0*(\d+)$", re.IGNORECASE),

tests/test_designation_rules.py

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
("CAT JHHMMSSss+DDMMSSs", "2MASXJ09592150-2733330", "2MASX J09592150-2733330"),
1212
("CAT JHHMMSSss+DDMMSSs", "2MASXJ10274703+2725368", "2MASX J10274703+2725368"),
1313
("CAT JHHMMSSss+DDMMSSs", "2masxj09592150-2733330", "2MASX J09592150-2733330"),
14+
("CAT HHMMSSs+DDMMSS", "SMDG1103517+284120", "SMDG 1103517+284120"),
1415
("CAT JHHMMSS.sss+DDMMSS.sss", "SDSSJ121551.62+573421.6", "SDSS J121551.62+573421.6"),
1516
("CAT JHHMMSS.sss+DDMMSS.sss", "SDSSJ121552.44+294932.9", "SDSS J121552.44+294932.9"),
1617
("CAT JHHMMSS.sss+DDMMSS.sss", "SDSSJ121553.17+202452.4", "SDSS J121553.17+202452.4"),
@@ -27,14 +28,19 @@
2728
("CAT JHHMMSS.sss+DDMMSS.sss", "WINGSJ132627.17-271414.2", "WINGS J132627.17-271414.2"),
2829
("CAT JHHMMSS.sss+DDMMSS.sss", "wingsj125634.96-173656.6", "WINGS J125634.96-173656.6"),
2930
("CAT JHHMMSS.sss+DDMMSS.sss", "WINGS J125634.96-173656.6", None),
30-
("CAT JHHMM+DDMM", "LVJ1235-1104", "LV J1235-1104"),
31-
("CAT JHHMM+DDMM", "LVJ1052+3628", "LV J1052+3628"),
32-
("CAT JHHMM+DDMM", "lvj1235-1104", "LV J1235-1104"),
3331
("CAT JHHMMSS.sss+DDMMSS.sss", "2QZJ233027.0-280856", "2QZ J233027.0-280856"),
3432
("CAT JHHMMSS.sss+DDMMSS.sss", "2QZJ121201.1+012648", "2QZ J121201.1+012648"),
3533
("CAT JHHMMSS.sss+DDMMSS.sss", "2QZJ103110.2+001703", "2QZ J103110.2+001703"),
3634
("CAT JHHMMSS.sss+DDMMSS.sss", "2qzj233027.0-280856", "2QZ J233027.0-280856"),
3735
("CAT JHHMMSS.sss+DDMMSS.sss", "2QZJ233027-280856", "2QZ J233027-280856"),
36+
("CAT JHHMMSS.sss+DDMMSS.sss", "LAMOSTJ003619.93+320329.5", "LAMOST J003619.93+320329.5"),
37+
("CAT JHHMMSS.sss+DDMMSS.sss", "LAMOSTJ022723.16+013324.5", "LAMOST J022723.16+013324.5"),
38+
("CAT JHHMMSS.sss+DDMMSS.sss", "lamostj085334.71+262244.1", "LAMOST J085334.71+262244.1"),
39+
("CAT JHHMMSS.sss+DDMMSS.sss", "LAMOSTJ003619+320329", "LAMOST J003619+320329"),
40+
("CAT JHHMMSS.sss+DDMMSS.sss", "", None),
41+
("CAT JHHMM+DDMM", "LVJ1235-1104", "LV J1235-1104"),
42+
("CAT JHHMM+DDMM", "LVJ1052+3628", "LV J1052+3628"),
43+
("CAT JHHMM+DDMM", "lvj1235-1104", "LV J1235-1104"),
3844
("CAT J HHMM+DD", "HIPASSJ1558-10", "HIPASS J1558-10"),
3945
("CAT J HHMM+DD", "HIPASS J1348-37", "HIPASS J1348-37"),
4046
("CAT J HHMM+DD", "HIPASS J0916-23b", "HIPASS J0916-23b"),
@@ -43,7 +49,6 @@
4349
("CAT J HHMM+DD", "HIPASS 1348-37", "HIPASS 1348-37"),
4450
("CAT J HHMM+DD", "SMDG1256-00", "SMDG 1256-00"),
4551
("CAT J HHMM+DD", "SMDG0740+40", "SMDG 0740+40"),
46-
("CAT HHMMSSs+DDMMSS", "SMDG1103517+284120", "SMDG 1103517+284120"),
4752
("CAT J HHMM+DD", "smdg1349+04", "SMDG 1349+04"),
4853
("CAT J HHMM+DD", "SMDG 1256-00", "SMDG 1256-00"),
4954
("CAT J HHMM+DD", "SMDG1256-0", None),
@@ -61,6 +66,12 @@
6166
("CAT J HHMM+DD", "fashi0237+38", "FASHI 0237+38"),
6267
("CAT J HHMM+DD", "FASHI1334+6", None),
6368
("CAT J HHMM+DD", "", None),
69+
("CAT HHMM+DDMM", "MAGE1423+5613", "MAGE 1423+5613"),
70+
("CAT HHMM+DDMM", "MAGE0740+1651", "MAGE 0740+1651"),
71+
("CAT HHMM+DDMM", "mage1132+5311", "MAGE 1132+5311"),
72+
("CAT HHMM+DDMM", "MAGE 1423+5613", "MAGE 1423+5613"),
73+
("CAT HHMM+DDMM", "MAGE1423+561", None),
74+
("CAT HHMM+DDMM", "", None),
6475
("[REF]J", "[BZZ2000]J132523.95-305406.7", "[BZZ2000] J132523.95-305406.7"),
6576
("[REF]J", "[BZZ2000] J132523.95-305406.7", "[BZZ2000] J132523.95-305406.7"),
6677
("[REF]J", "[IBG2003]J114222+195346", "[IBG2003] J114222+195346"),
@@ -289,12 +300,6 @@
289300
("ISI96", "isi96_0922+0233", "ISI96_0922+0233"),
290301
("ISI96", "ISI96_1450+023", None),
291302
("ISI96", "", None),
292-
("MAGE", "MAGE1423+5613", "MAGE 1423+5613"),
293-
("MAGE", "MAGE0740+1651", "MAGE 0740+1651"),
294-
("MAGE", "mage1132+5311", "MAGE 1132+5311"),
295-
("MAGE", "MAGE 1423+5613", "MAGE 1423+5613"),
296-
("MAGE", "MAGE1423+561", None),
297-
("MAGE", "", None),
298303
("AM", "AM 0316-484", "AM 0316-484"),
299304
("AM", "AM2220-460", "AM 2220-460"),
300305
("AM", "am0316-484", "AM 0316-484"),
@@ -353,11 +358,6 @@
353358
("CNOC2", "CNOC2_0223.090502", "CNOC2_0223.090502"),
354359
("CNOC2", "CNOC20223.051394", None),
355360
("CNOC2", "", None),
356-
("LAMOST", "LAMOSTJ003619.93+320329.5", "LAMOST J003619.93+320329.5"),
357-
("LAMOST", "LAMOSTJ022723.16+013324.5", "LAMOST J022723.16+013324.5"),
358-
("LAMOST", "lamostj085334.71+262244.1", "LAMOST J085334.71+262244.1"),
359-
("LAMOST", "LAMOSTJ003619+320329", "LAMOST J003619+320329"),
360-
("LAMOST", "", None),
361361
("2MFGC", "2MFGC15266", "2MFGC 15266"),
362362
("2MFGC", "2MFGC 15266", "2MFGC 15266"),
363363
("2MFGC", "2mfgc15266", "2MFGC 15266"),

0 commit comments

Comments
 (0)