Skip to content

Commit 84cc228

Browse files
billybonksbillybonks
authored
Merge pull request #54 from Hyper-Unearthing/perf/fix-lighthouse
Perf/fix lighthouse
2 parents 0bf2577 + 033de2b commit 84cc228

4 files changed

Lines changed: 21 additions & 167 deletions

File tree

‎_includes/lazy-load.html‎

Lines changed: 0 additions & 152 deletions
This file was deleted.

‎_layouts/default.html‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
<meta name="viewport" content="width=device-width, initial-scale=1" />
1919
<meta charset="UTF-8" />
2020
<meta name="description" content="{{page.description}}" />
21-
{% include lazy-load.html %}
2221
<link rel="stylesheet" href="{% fingerprint /assets/main.css %}" />
2322
<link rel="stylesheet" href="{% fingerprint /assets/pasta/reset.css %}" />
2423
<link rel="stylesheet" href="{% fingerprint /assets/pasta/colours.css %}" />
@@ -72,7 +71,7 @@
7271
<body class="dark">
7372
<div class="navigation">
7473
<div class="navigation__left">
75-
<img class="logo" alt="logo" data-echo="/assets/images/mb-mark.svg" />
74+
<img class="logo" alt="logo" src="/assets/images/mb-mark.svg" />
7675
<b class="logo-text">managerbot</b>
7776
</div>
7877
<div class="navigation__right">
@@ -82,7 +81,7 @@
8281
class="button secondary"
8382
>
8483
Create Account
85-
<img data-echo="/assets/images/heart.svg" alt="" class="heart" />
84+
<img src="/assets/images/heart.svg" alt="" class="heart" />
8685
</a>
8786
</div>
8887
</div>

‎assets/components/full-width-layout.css‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,9 @@
9191
font-weight: 200;
9292
}
9393

94-
.metrics .list h4 {
94+
.metrics .list h3 {
9595
margin-bottom: 17px;
96+
font-size: 24px;
9697
}
9798

9899
.metrics-grid {

‎index.html‎

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -41,13 +41,15 @@ <h2>The Non-Linear Reality of the Pull Request Lifecycle</h2>
4141
</div>
4242
<img
4343
class="desktop"
44-
data-echo="/assets/images/img-non-linear@2x.png"
44+
src="/assets/images/img-non-linear@2x.png"
4545
alt="shows inneficiencies of team"
46+
loading="lazy"
4647
/>
4748
<img
4849
class="mobile"
49-
data-echo="/assets/images/img-non-linear-mobile@2x.png"
50+
src="/assets/images/img-non-linear-mobile@2x.png"
5051
alt="shows inneficiencies of team"
52+
loading="lazy"
5153
/>
5254
</section>
5355
<section class="full-width-layout new-way">
@@ -64,16 +66,18 @@ <h2>
6466
</div>
6567
<img
6668
class="desktop"
67-
data-echo="/assets/images/chart-leadtime@2x.png"
69+
src="/assets/images/chart-leadtime@2x.png"
6870
alt="Pull Request Lead Time"
71+
loading="lazy"
6972
/>
7073
</div>
7174
<div class="metrics">
7275
<div class="banner">
7376
<img
7477
class="desktop"
75-
data-echo="/assets/images/happy-graph.svg"
78+
src="/assets/images/happy-graph.svg"
7679
alt="graph that is heading in positive direction"
80+
loading="lazy"
7781
/>
7882
<h2>Key Metrics by ManagerBot</h2>
7983
<p>
@@ -84,7 +88,7 @@ <h2>Key Metrics by ManagerBot</h2>
8488
<div class="list metrics-grid">
8589
<div class="metrics-top">
8690
<span class="badge">1</span>
87-
<h4>Pull request health:</h4>
91+
<h3>Pull request health:</h3>
8892
<ol>
8993
<li>Lead Time</li>
9094
<li>Draft Time</li>
@@ -97,15 +101,15 @@ <h4>Pull request health:</h4>
97101
</div>
98102
<div class="metrics-bottom-left">
99103
<span class="badge">2</span>
100-
<h4>Developer load:</h4>
104+
<h3>Developer load:</h3>
101105
<ol>
102106
<li>Pull Requests per Developer</li>
103107
<li>Reviews per Developer</li>
104108
</ol>
105109
</div>
106110
<div class="metrics-bottom-right">
107111
<span class="badge">3</span>
108-
<h4>Continuous integration:</h4>
112+
<h3>Continuous integration:</h3>
109113
<ol>
110114
<li>CI Run Time Growth</li>
111115
<li>CI Usage by User Type</li>
@@ -118,12 +122,13 @@ <h4>Continuous integration:</h4>
118122
<div class="colomnar-layout notifications">
119123
<section>
120124
<div class="logos desktop">
121-
<img src="assets/images/slack.png" alt="Slack" width="50" height="50" />
125+
<img src="assets/images/slack.png" alt="Slack" width="50" height="50" loading="lazy" />
122126
<img
123127
src="assets/images/icon-discord.svg"
124128
alt="Discord"
125129
width="50"
126130
height="50"
131+
loading="lazy"
127132
/>
128133
</div>
129134
<h2>
@@ -135,16 +140,17 @@ <h2>
135140
</p>
136141
</section>
137142
<div class="logos mobile">
138-
<img src="assets/images/slack.png" alt="Slack" width="50" height="50" />
143+
<img src="assets/images/slack.png" alt="Slack" width="50" height="50" loading="lazy" />
139144
<img
140145
src="assets/images/icon-discord.svg"
141146
alt="Discord"
142147
width="50"
143148
height="50"
149+
loading="lazy"
144150
/>
145151
</div>
146152
<section>
147-
<img src="assets/images/slack-screenshot.png" />
153+
<img src="assets/images/slack-screenshot.png" alt="Slack notification showing pull request reminder" loading="lazy" />
148154
</section>
149155
</div>
150156
<div class="colomnar-layout getting-started">
@@ -224,7 +230,7 @@ <h2>
224230
</form>
225231
</section>
226232
<section>
227-
<img class="happy-dev" src="assets/images/happy-dev.svg" />
233+
<img class="happy-dev" src="assets/images/happy-dev.svg" alt="Happy developer illustration" loading="lazy" />
228234
<h2>Get started with your free ManagerBot Account</h2>
229235
<p>
230236
Translate Pull Request data into impactful engineering decisions with

0 commit comments

Comments
 (0)