From a2d024bf610f4a9b4dd259de4afaabab96c93366 Mon Sep 17 00:00:00 2001 From: Tyler Kindy Date: Wed, 22 Oct 2025 09:47:34 -0400 Subject: [PATCH 1/5] Use latest version of basepom --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 5bd94e37f..c1fb5be78 100644 --- a/pom.xml +++ b/pom.xml @@ -5,7 +5,7 @@ com.hubspot basepom - 63.4 + 65.1 com.hubspot.jinjava From 8c72b77130dae64b2142b2b7e4221647cb4ebcd2 Mon Sep 17 00:00:00 2001 From: Tyler Kindy Date: Wed, 22 Oct 2025 10:10:29 -0400 Subject: [PATCH 2/5] Remove unreferenced property --- pom.xml | 1 - 1 file changed, 1 deletion(-) diff --git a/pom.xml b/pom.xml index c1fb5be78..ee6cd7555 100644 --- a/pom.xml +++ b/pom.xml @@ -17,7 +17,6 @@ 17 - 17 0.8.3 3.0.1 From 0d160a7ec41c193366f1d5467f6b2320e680074c Mon Sep 17 00:00:00 2001 From: Tyler Kindy Date: Wed, 22 Oct 2025 09:55:46 -0400 Subject: [PATCH 3/5] Properly set JDK versions --- .build-jdk17 | 0 .github/workflows/ci.yml | 14 ++++++++++++-- 2 files changed, 12 insertions(+), 2 deletions(-) delete mode 100644 .build-jdk17 diff --git a/.build-jdk17 b/.build-jdk17 deleted file mode 100644 index e69de29bb..000000000 diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9b957b071..5b70b0e9e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -16,9 +16,19 @@ jobs: - uses: actions/setup-java@v3 with: distribution: "temurin" - java-version: ${{ matrix.java }} + # The JDK listed last will be the default and what Maven runs with + # https://github.com/marketplace/actions/setup-java-jdk#install-multiple-jdks + java-version: | + ${{ matrix.java }} + 25 cache: "maven" - name: "Build" - run: mvn --batch-mode -no-transfer-progress -V verify + run: | + mvn \ + --batch-mode \ + -no-transfer-progress \ + -V \ + -Dproject.build.jdk.version=${{ matrix.java }} \ + verify env: JDK_JAVA_OPTIONS: --add-opens=java.base/java.lang=ALL-UNNAMED From 430c38c6f9a8fbbe01823d0aafcd77223896ce41 Mon Sep 17 00:00:00 2001 From: Tyler Kindy Date: Wed, 22 Oct 2025 10:34:46 -0400 Subject: [PATCH 4/5] Run tests on all active LTS JDKs --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5b70b0e9e..10338025d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -7,7 +7,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - java: [ 17 ] + java: [ 17, 21, 25 ] name: jdk-${{ matrix.java }} steps: - uses: actions/checkout@v3 From 4b039672816dd2298f0aac1bc12202deda3e2c97 Mon Sep 17 00:00:00 2001 From: Tyler Kindy Date: Wed, 22 Oct 2025 11:21:35 -0400 Subject: [PATCH 5/5] Fix 25 build --- pom.xml | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/pom.xml b/pom.xml index ee6cd7555..98aec544c 100644 --- a/pom.xml +++ b/pom.xml @@ -22,6 +22,7 @@ 3.0.1 1.9 1.5 + 5.20.0 @@ -180,6 +181,10 @@ ch.obermuhlner big-math + + com.google.errorprone + error_prone_annotations + ch.qos.logback @@ -335,6 +340,18 @@ @{argLine} ${basepom.test.add.opens} + + org.apache.maven.plugins + maven-compiler-plugin + + + + org.immutables + value + + + +