fix a nasty hack in the code to access the second element from the stack - this hack was broken during the switch from Stack to Deque (see #45)

Author: rbri

src/main/java/org/htmlunit/cssparser/parser/CSSOMParser.java

@@ -17,9 +17,8 @@
 import java.io.IOException;
 import java.io.StringReader;
 import java.util.ArrayDeque;
-import java.util.ArrayList;
 import java.util.Deque;
-import java.util.List;
+import java.util.Iterator;
 
 import org.htmlunit.cssparser.dom.AbstractCSSRuleImpl;
 import org.htmlunit.cssparser.dom.CSSCharsetRuleImpl;
@@ -423,8 +422,9 @@ public void property(final String name, final LexicalUnit value, final boolean i
 
         private AbstractCSSRuleImpl getParentRule() {
             if (!nodeStack_.isEmpty() && nodeStack_.size() > 1) {
-                final List<Object> nodesStack = new ArrayList<>(nodeStack_);
-                final Object node = nodesStack.get(nodesStack.size() - 2);
+                final Iterator<Object> iter = nodeStack_.iterator();
+                iter.next(); // skip first
+                final Object node = iter.next();
                 if (node instanceof AbstractCSSRuleImpl) {
                     return (AbstractCSSRuleImpl) node;
                 }

src/test/java/org/htmlunit/cssparser/dom/CSSMediaRuleImplTest.java

@@ -45,6 +45,19 @@ public void getCssText() throws Exception {
         assertEquals("@media print {\n  body { font-size: 10pt; }\n}", mediaRule.getCssText());
     }
 
+    /**
+     * @throws Exception if any error occurs
+     */
+    @Test
+    public void getParentRule() throws Exception {
+        final CSSOMParser parser = new CSSOMParser();
+        final InputSource source = new InputSource(new StringReader("@media print { body { font-size: 10pt } }"));
+        final CSSStyleSheetImpl ss = parser.parseStyleSheet(source, null);
+
+        final CSSMediaRuleImpl mediaRule = (CSSMediaRuleImpl) ss.getCssRules().getRules().get(0);
+        assertEquals(mediaRule, mediaRule.getCssRules().getRules().get(0).getParentRule());
+    }
+
     /**
      * @throws Exception if any error occurs
      */
@@ -62,17 +75,25 @@ public void insertRule() throws Exception {
         mediaRule.insertRule(".testStyle { height: 43px; }", 0);
         assertEquals("*.testStyle { height: 43px; }", mediaRule.getCssRules().getRules().get(0).getCssText());
         assertEquals("*.testStyle { height: 42px; }", mediaRule.getCssRules().getRules().get(1).getCssText());
+        assertEquals("@media print {\n  *.testStyle { height: 43px; }\n  *.testStyle { height: 42px; }\n}",
+                mediaRule.getCssRules().getRules().get(0).getParentRule().getCssText());
 
         mediaRule.insertRule(".testStyle { height: 44px; }", 2);
         assertEquals("*.testStyle { height: 43px; }", mediaRule.getCssRules().getRules().get(0).getCssText());
         assertEquals("*.testStyle { height: 42px; }", mediaRule.getCssRules().getRules().get(1).getCssText());
         assertEquals("*.testStyle { height: 44px; }", mediaRule.getCssRules().getRules().get(2).getCssText());
+        assertEquals("@media print {\n  *.testStyle { height: 43px; }"
+                + "\n  *.testStyle { height: 42px; }\n  *.testStyle { height: 44px; }\n}",
+                mediaRule.getCssRules().getRules().get(0).getParentRule().getCssText());
 
         mediaRule.insertRule(".testStyle { height: 45px; }", 2);
         assertEquals("*.testStyle { height: 43px; }", mediaRule.getCssRules().getRules().get(0).getCssText());
         assertEquals("*.testStyle { height: 42px; }", mediaRule.getCssRules().getRules().get(1).getCssText());
         assertEquals("*.testStyle { height: 45px; }", mediaRule.getCssRules().getRules().get(2).getCssText());
         assertEquals("*.testStyle { height: 44px; }", mediaRule.getCssRules().getRules().get(3).getCssText());
+        assertEquals("@media print {\n  *.testStyle { height: 43px; }\n  *.testStyle { height: 42px; }"
+                + "\n  *.testStyle { height: 45px; }\n  *.testStyle { height: 44px; }\n}",
+                mediaRule.getCssRules().getRules().get(0).getParentRule().getCssText());
     }
 
     /**