forked from arkworks-rs/snark
-
Notifications
You must be signed in to change notification settings - Fork 18
Misc optimizations for group gadgets #125
Copy link
Copy link
Open
Labels
documentationImprovements or additions to documentationImprovements or additions to documentationenhancementNew feature or requestNew feature or requestnice to havePossible new feature to introducePossible new feature to introduceoptimizationPerformance improvement for the current codebasePerformance improvement for the current codebase
Metadata
Metadata
Assignees
Labels
documentationImprovements or additions to documentationImprovements or additions to documentationenhancementNew feature or requestNew feature or requestnice to havePossible new feature to introducePossible new feature to introduceoptimizationPerformance improvement for the current codebasePerformance improvement for the current codebase
mul_bits_fixed_basewe can optimize performances by applying the batch inversion to the whole table and not only to the table obtained by packing 2 bits at a time;mul_bitsandmul_bits_fixed_basefunctions to transparently handle exceptional cases if arithmetic is incomplete (shift + conditional selection of the result);r. Let's take a more accurate measure instead of the Hamming weight to pick out the most efficient test..*fixed_base.*) that computes the power of the bases(s) inside or accepting already the precomputed powers of the base(s) as input parameter. I would suggest to keep the latters, as we can always precompute the powers of the base(s), save them somewhere, and pass references to them to the circuit whenever needed. We should address also the functions left todo!() in the implementers of GroupGadget trait.Iterator<bool>instead ofVec<bool>