The rename of homeric_exporter_scrape_timestamp was part of #100. A quick scan shows nats_jetstream_bytes and nats_jetstream_messages carry no unit suffix, and nats_in_bytes_total / nats_out_bytes_total use _total (counter convention) on a gauge. All metric names should be audited against Prometheus naming best practices (unit suffix for gauges, _total reserved for counters).
Follow-up from #156
The rename of
homeric_exporter_scrape_timestampwas part of #100. A quick scan showsnats_jetstream_bytesandnats_jetstream_messagescarry no unit suffix, andnats_in_bytes_total/nats_out_bytes_totaluse_total(counter convention) on a gauge. All metric names should be audited against Prometheus naming best practices (unit suffix for gauges,_totalreserved for counters).Follow-up from #156