From 5afdc43be4d2cc0c99beb8ab87b366b3999e9503 Mon Sep 17 00:00:00 2001
From: hshum <hshum@users.noreply.github.com>
Date: Sat, 30 May 2026 16:38:38 -0700
Subject: [PATCH] =?UTF-8?q?fix(scratchnode):=20never=20silently=20drop=20a?=
 =?UTF-8?q?=20cold-load=20send=20=E2=80=94=20queue=20until=20the=20live=20?=
 =?UTF-8?q?room=20is=20ready?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

PR B of the /ask launch-readiness sprint.

Root cause (found during PR #443 live verification): in home-v5.html the Convex-
routing send override is installed only AFTER the async init — lazy-loading the
browser client from esm.sh, then `await joinEvent`. Until that completes,
window.sendComposerMessage is still the prototype-only handler: it clears the
composer and renders locally but NEVER persists to Convex. A public chat / `/ask`
fired in that cold-load window is silently lost — the user believes it sent. This
is exactly the first-send failure observed live (it was NOT an Enter-key bug, and
NOT the member-row race — the not_joined auto-retry already covers that).

Fix (additive, frontend-only):
- Install an early queueing shim BEFORE the client-load + join awaits. Public
  sends are buffered into window._sn_pendingSends (not lost); the composer clears
  and shows a "Connecting to live room…" hint. Private notes still pass straight
  to the prototype handler.
- The real Convex override drains the queue the moment it installs — replaying
  each buffered draft through the full sendMessage → askAgent path, in order.
- If init fails (client load or join), _sn_failPendingSends restores the most
  recent un-sent draft to the composer + toasts, instead of dropping it.

Verification: all 4 inline <script> blocks pass `node --check` (the live-room
block is type=module / strict mode). Behavioral cold-load verification runs
post-deploy on the live showcase per .claude/rules/live_dom_verification.md
(static proto HTML isn't covered by tsc/build).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
 public/proto/home-v5.html | 55 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 55 insertions(+)

diff --git a/public/proto/home-v5.html b/public/proto/home-v5.html
index 2d6037bb..62ef9e0f 100644
--- a/public/proto/home-v5.html
+++ b/public/proto/home-v5.html
@@ -5421,6 +5421,45 @@ <h2 id="kbd-title">Keyboard shortcuts</h2>
     return;
   }
 
+  // ─── Cold-load send guard (PR B) ───────────────────────────────────
+  // Until the Convex-routing override installs below (AFTER the browser client
+  // lazy-loads AND joinEvent resolves), window.sendComposerMessage is still the
+  // prototype-only handler — it clears the composer and renders locally but
+  // NEVER persists to Convex. A public send fired in this cold-load window would
+  // be silently lost (the user thinks it sent). Install a queueing shim now:
+  // public sends are buffered (not lost), the composer clears, and a "connecting"
+  // hint shows. The real override drains the queue the moment the room is live;
+  // if init fails, _sn_failPendingSends restores the draft instead of dropping it.
+  window._sn_pendingSends = [];
+  const _preInitSend = window.sendComposerMessage;
+  window.sendComposerMessage = function() {
+    const input = document.getElementById('ci');
+    if (!input) return;
+    const intent = window.parseComposerIntent && window.parseComposerIntent(input.value);
+    if (!intent) { input.focus(); return; }
+    // Private notes stay 100% prototype-side and never touch Convex — pass through.
+    if (intent.visibility === 'private') { return _preInitSend.call(this); }
+    window._sn_pendingSends.push(input.value);
+    input.value = '';
+    if ('ontouchstart' in window || window.innerWidth <= 720) input.blur();
+    if (typeof toast === 'function') {
+      toast('Connecting to live room…', 'Your message will send the moment the room is live.');
+    }
+  };
+  window.send = window.sendComposerMessage;
+  window._sn_failPendingSends = function() {
+    if (!window._sn_pendingSends || !window._sn_pendingSends.length) return;
+    const input = document.getElementById('ci');
+    const lastDraft = window._sn_pendingSends[window._sn_pendingSends.length - 1];
+    window._sn_pendingSends = [];
+    // Restore the most recent un-sent draft so the user can retry once the room
+    // recovers — never silently drop what they typed.
+    if (input && !input.value) input.value = lastDraft;
+    if (typeof toast === 'function') {
+      toast('Live room unavailable', 'Your message was not sent — your draft is restored. Retry once the room loads.');
+    }
+  };
+
   // ─── Lazy-load Convex browser client ───────────────────────────────
   let ConvexClient;
   try {
@@ -5430,6 +5469,7 @@ <h2 id="kbd-title">Keyboard shortcuts</h2>
   } catch (e) {
     console.warn('[scratchnode] Convex client load failed, live room unavailable:', e.message);
     showLiveRoomError('Could not load the realtime client. <a href="javascript:location.reload()" style="color:#f1d6c8;text-decoration:underline">Retry</a>');
+    window._sn_failPendingSends && window._sn_failPendingSends();
     return;
   }
 
@@ -5452,6 +5492,7 @@ <h2 id="kbd-title">Keyboard shortcuts</h2>
     showLiveRoomError(notFound
       ? 'No room matches <code style="font-family:var(--mono,monospace);background:#2a1f1c;padding:2px 6px;border-radius:4px">/e/' + (slug.replace(/[<>&"]/g, '') || '?') + '</code>. <a href="/" style="color:#f1d6c8;text-decoration:underline">Back to landing</a> or check your room code.'
       : 'Could not connect to the live room. <a href="javascript:location.reload()" style="color:#f1d6c8;text-decoration:underline">Retry</a>');
+    window._sn_failPendingSends && window._sn_failPendingSends();
     return;
   }
   const eventId = joined.eventId;
@@ -5681,6 +5722,20 @@ <h2 id="kbd-title">Keyboard shortcuts</h2>
   // Make sure both global aliases stay in sync (existing onclick handlers).
   window.send = window.sendComposerMessage;
 
+  // Drain any public sends queued during the cold-load init window (PR B). The
+  // real override reads #ci, so replay each buffered draft through it in order —
+  // each goes through the full Convex sendMessage → askAgent path and clears.
+  if (window._sn_pendingSends && window._sn_pendingSends.length) {
+    const _queued = window._sn_pendingSends.splice(0);
+    const _ci = document.getElementById('ci');
+    if (_ci) {
+      for (let _i = 0; _i < _queued.length; _i += 1) {
+        _ci.value = _queued[_i];
+        window.sendComposerMessage();
+      }
+    }
+  }
+
   window.snSuggestFaq = function(answerId) {
     client.mutation('events:suggestAnswerForFaq', { eventId, answerId, sessionId })
       .then(() => toast('Suggested for FAQ', 'The host can promote this into the public wiki.'))