From 62b9ce1136d7f04ce400599225b912184eb77ad6 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Fri, 22 May 2026 07:17:59 +0000 Subject: [PATCH] =?UTF-8?q?=F0=9F=A7=B9=20[code=20health=20improvement]=20?= =?UTF-8?q?Remove=20any=20cast=20in=20LayoutEditor.test.tsx?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 🎯 **What:** Removed instances of `(window as any)` and related `eslint-disable-next-line` comments in `LayoutEditor.test.tsx`. 💡 **Why:** Relying on `any` bypasses TypeScript's type checking, making the code more error-prone and harder to understand. By defining an explicit `MockWindow` interface, we clearly specify the expected shape of the mocked properties on the window object. This improves type safety and removes the need for eslint suppression comments. ✅ **Verification:** Ran `npm run lint` and `npm run test src/components/__tests__/LayoutEditor.test.tsx`. The tests pass and there are no linting errors related to this file. ✨ **Result:** A cleaner, safer test file with properly typed mock window access. Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com> --- .../__tests__/LayoutEditor.test.tsx | 37 ++++++++----------- 1 file changed, 16 insertions(+), 21 deletions(-) diff --git a/src/components/__tests__/LayoutEditor.test.tsx b/src/components/__tests__/LayoutEditor.test.tsx index fb53039..5c113ef 100644 --- a/src/components/__tests__/LayoutEditor.test.tsx +++ b/src/components/__tests__/LayoutEditor.test.tsx @@ -4,6 +4,11 @@ import LayoutEditor from "../LayoutEditor"; import { CardLayout } from "@/lib/types"; import "@testing-library/jest-dom"; +interface MockWindow { + triggerDragEnd?: (event: unknown) => void; + mockIsOverId?: string; +} + // Mock dnd-kit components vi.mock("@dnd-kit/core", async (importOriginal) => { const actual = await importOriginal(); @@ -13,7 +18,7 @@ vi.mock("@dnd-kit/core", async (importOriginal) => {
{ // Expose a way to trigger onDragEnd via a synthetic event or global for testing // We'll attach it to window for easy triggering - (window as unknown as { triggerDragEnd: (event: unknown) => void }).triggerDragEnd = onDragEnd; + (window as unknown as MockWindow).triggerDragEnd = onDragEnd; }}> {children}
@@ -22,8 +27,7 @@ vi.mock("@dnd-kit/core", async (importOriginal) => { useSensor: vi.fn(() => ({})), useDroppable: ({ id }: { id: string }) => ({ setNodeRef: vi.fn(), - // eslint-disable-next-line @typescript-eslint/no-explicit-any - isOver: (window as any).mockIsOverId === id, + isOver: (window as unknown as MockWindow).mockIsOverId === id, }), PointerSensor: vi.fn(), KeyboardSensor: vi.fn(), @@ -64,10 +68,8 @@ describe("LayoutEditor", () => { beforeEach(() => { mockOnLayoutChange = vi.fn(); mockOnToggleVisibility = vi.fn(); - // eslint-disable-next-line @typescript-eslint/no-explicit-any - (window as any).triggerDragEnd = undefined; - // eslint-disable-next-line @typescript-eslint/no-explicit-any - (window as any).mockIsOverId = undefined; + (window as unknown as MockWindow).triggerDragEnd = undefined; + (window as unknown as MockWindow).mockIsOverId = undefined; }); it("renders blocks in their respective columns", () => { @@ -119,8 +121,7 @@ describe("LayoutEditor", () => { const dndContext = screen.getByTestId("dnd-context"); fireEvent.click(dndContext); - // eslint-disable-next-line @typescript-eslint/no-explicit-any - const triggerDragEnd = (window as any).triggerDragEnd; + const triggerDragEnd = (window as unknown as MockWindow).triggerDragEnd!; expect(triggerDragEnd).toBeDefined(); // Drag 'avatar' to 'right' column @@ -149,8 +150,7 @@ describe("LayoutEditor", () => { const dndContext = screen.getByTestId("dnd-context"); fireEvent.click(dndContext); - // eslint-disable-next-line @typescript-eslint/no-explicit-any - const triggerDragEnd = (window as any).triggerDragEnd; + const triggerDragEnd = (window as unknown as MockWindow).triggerDragEnd!; // Drag 'avatar' over 'topLanguages' triggerDragEnd({ @@ -178,8 +178,7 @@ describe("LayoutEditor", () => { const dndContext = screen.getByTestId("dnd-context"); fireEvent.click(dndContext); - // eslint-disable-next-line @typescript-eslint/no-explicit-any - const triggerDragEnd = (window as any).triggerDragEnd; + const triggerDragEnd = (window as unknown as MockWindow).triggerDragEnd!; triggerDragEnd({ active: { id: "avatar" }, over: null, @@ -200,8 +199,7 @@ describe("LayoutEditor", () => { const dndContext = screen.getByTestId("dnd-context"); fireEvent.click(dndContext); - // eslint-disable-next-line @typescript-eslint/no-explicit-any - const triggerDragEnd = (window as any).triggerDragEnd; + const triggerDragEnd = (window as unknown as MockWindow).triggerDragEnd!; triggerDragEnd({ active: { id: "avatar" }, over: { id: "avatar" }, @@ -222,8 +220,7 @@ describe("LayoutEditor", () => { const dndContext = screen.getByTestId("dnd-context"); fireEvent.click(dndContext); - // eslint-disable-next-line @typescript-eslint/no-explicit-any - const triggerDragEnd = (window as any).triggerDragEnd; + const triggerDragEnd = (window as unknown as MockWindow).triggerDragEnd!; triggerDragEnd({ active: { id: "avatar" }, over: { id: "non-existent-block" }, @@ -250,8 +247,7 @@ describe("LayoutEditor", () => { const dndContext = screen.getByTestId("dnd-context"); fireEvent.click(dndContext); - // eslint-disable-next-line @typescript-eslint/no-explicit-any - const triggerDragEnd = (window as any).triggerDragEnd; + const triggerDragEnd = (window as unknown as MockWindow).triggerDragEnd!; // Drag 'avatar' over 'stats' (downwards) triggerDragEnd({ @@ -278,8 +274,7 @@ describe("LayoutEditor", () => { const dndContext = screen.getByTestId("dnd-context"); fireEvent.click(dndContext); - // eslint-disable-next-line @typescript-eslint/no-explicit-any - const triggerDragEnd = (window as any).triggerDragEnd; + const triggerDragEnd = (window as unknown as MockWindow).triggerDragEnd!; // Drag 'avatar' to empty column 'right' triggerDragEnd({