From 6b72ff766f74d10d6f34756fd9bd83591bad730c Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Fri, 22 May 2026 07:06:29 +0000 Subject: [PATCH] =?UTF-8?q?=F0=9F=A7=B9=20[code=20health=20improvement]=20?= =?UTF-8?q?Remove=20any=20type=20and=20eslint-disable=20comments=20in=20La?= =?UTF-8?q?youtEditor.test.tsx?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com> --- .../__tests__/LayoutEditor.test.tsx | 55 +++++++++---------- 1 file changed, 25 insertions(+), 30 deletions(-) diff --git a/src/components/__tests__/LayoutEditor.test.tsx b/src/components/__tests__/LayoutEditor.test.tsx index fb53039..325c57a 100644 --- a/src/components/__tests__/LayoutEditor.test.tsx +++ b/src/components/__tests__/LayoutEditor.test.tsx @@ -2,18 +2,23 @@ import { render, screen, fireEvent } from "@testing-library/react"; import { describe, it, expect, vi, beforeEach } from "vitest"; import LayoutEditor from "../LayoutEditor"; import { CardLayout } from "@/lib/types"; -import "@testing-library/jest-dom"; + + +type WindowWithMock = Window & typeof globalThis & { + triggerDragEnd?: (event: { active: { id: string }, over: { id: string } | null }) => void; + mockIsOverId?: string; +}; // Mock dnd-kit components vi.mock("@dnd-kit/core", async (importOriginal) => { const actual = await importOriginal(); return { ...actual, - DndContext: ({ children, onDragEnd }: { children: React.ReactNode; onDragEnd: (event: unknown) => void }) => ( + DndContext: ({ children, onDragEnd }: { children: React.ReactNode; onDragEnd: (event: { active: { id: string }, over: { id: string } | null }) => void }) => (
{ // Expose a way to trigger onDragEnd via a synthetic event or global for testing // We'll attach it to window for easy triggering - (window as unknown as { triggerDragEnd: (event: unknown) => void }).triggerDragEnd = onDragEnd; + (window as WindowWithMock).triggerDragEnd = onDragEnd; }}> {children}
@@ -22,8 +27,7 @@ vi.mock("@dnd-kit/core", async (importOriginal) => { useSensor: vi.fn(() => ({})), useDroppable: ({ id }: { id: string }) => ({ setNodeRef: vi.fn(), - // eslint-disable-next-line @typescript-eslint/no-explicit-any - isOver: (window as any).mockIsOverId === id, + isOver: (window as WindowWithMock).mockIsOverId === id, }), PointerSensor: vi.fn(), KeyboardSensor: vi.fn(), @@ -64,10 +68,8 @@ describe("LayoutEditor", () => { beforeEach(() => { mockOnLayoutChange = vi.fn(); mockOnToggleVisibility = vi.fn(); - // eslint-disable-next-line @typescript-eslint/no-explicit-any - (window as any).triggerDragEnd = undefined; - // eslint-disable-next-line @typescript-eslint/no-explicit-any - (window as any).mockIsOverId = undefined; + (window as WindowWithMock).triggerDragEnd = undefined; + (window as WindowWithMock).mockIsOverId = undefined; }); it("renders blocks in their respective columns", () => { @@ -119,12 +121,11 @@ describe("LayoutEditor", () => { const dndContext = screen.getByTestId("dnd-context"); fireEvent.click(dndContext); - // eslint-disable-next-line @typescript-eslint/no-explicit-any - const triggerDragEnd = (window as any).triggerDragEnd; + const triggerDragEnd = (window as WindowWithMock).triggerDragEnd; expect(triggerDragEnd).toBeDefined(); // Drag 'avatar' to 'right' column - triggerDragEnd({ + triggerDragEnd?.({ active: { id: "avatar" }, over: { id: "right" }, }); @@ -149,11 +150,10 @@ describe("LayoutEditor", () => { const dndContext = screen.getByTestId("dnd-context"); fireEvent.click(dndContext); - // eslint-disable-next-line @typescript-eslint/no-explicit-any - const triggerDragEnd = (window as any).triggerDragEnd; + const triggerDragEnd = (window as WindowWithMock).triggerDragEnd; // Drag 'avatar' over 'topLanguages' - triggerDragEnd({ + triggerDragEnd?.({ active: { id: "avatar" }, over: { id: "topLanguages" }, }); @@ -178,9 +178,8 @@ describe("LayoutEditor", () => { const dndContext = screen.getByTestId("dnd-context"); fireEvent.click(dndContext); - // eslint-disable-next-line @typescript-eslint/no-explicit-any - const triggerDragEnd = (window as any).triggerDragEnd; - triggerDragEnd({ + const triggerDragEnd = (window as WindowWithMock).triggerDragEnd; + triggerDragEnd?.({ active: { id: "avatar" }, over: null, }); @@ -200,9 +199,8 @@ describe("LayoutEditor", () => { const dndContext = screen.getByTestId("dnd-context"); fireEvent.click(dndContext); - // eslint-disable-next-line @typescript-eslint/no-explicit-any - const triggerDragEnd = (window as any).triggerDragEnd; - triggerDragEnd({ + const triggerDragEnd = (window as WindowWithMock).triggerDragEnd; + triggerDragEnd?.({ active: { id: "avatar" }, over: { id: "avatar" }, }); @@ -222,9 +220,8 @@ describe("LayoutEditor", () => { const dndContext = screen.getByTestId("dnd-context"); fireEvent.click(dndContext); - // eslint-disable-next-line @typescript-eslint/no-explicit-any - const triggerDragEnd = (window as any).triggerDragEnd; - triggerDragEnd({ + const triggerDragEnd = (window as WindowWithMock).triggerDragEnd; + triggerDragEnd?.({ active: { id: "avatar" }, over: { id: "non-existent-block" }, }); @@ -250,11 +247,10 @@ describe("LayoutEditor", () => { const dndContext = screen.getByTestId("dnd-context"); fireEvent.click(dndContext); - // eslint-disable-next-line @typescript-eslint/no-explicit-any - const triggerDragEnd = (window as any).triggerDragEnd; + const triggerDragEnd = (window as WindowWithMock).triggerDragEnd; // Drag 'avatar' over 'stats' (downwards) - triggerDragEnd({ + triggerDragEnd?.({ active: { id: "avatar" }, over: { id: "stats" }, }); @@ -278,11 +274,10 @@ describe("LayoutEditor", () => { const dndContext = screen.getByTestId("dnd-context"); fireEvent.click(dndContext); - // eslint-disable-next-line @typescript-eslint/no-explicit-any - const triggerDragEnd = (window as any).triggerDragEnd; + const triggerDragEnd = (window as WindowWithMock).triggerDragEnd; // Drag 'avatar' to empty column 'right' - triggerDragEnd({ + triggerDragEnd?.({ active: { id: "avatar" }, over: { id: "right" }, });