From 5fff52e988f817c6b35a2ccf220ee246649a71e5 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Fri, 22 May 2026 07:04:21 +0000 Subject: [PATCH] =?UTF-8?q?=F0=9F=A7=B9=20[code=20health]=20remove=20expli?= =?UTF-8?q?cit=20any=20and=20eslint-disable=20in=20LayoutEditor.test.tsx?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 🎯 What: Replaced `(window as any)` with a properly typed `MockWindow` interface extending `Window`, and removed associated `@typescript-eslint/no-explicit-any` comments. Added non-null assertion when assigning the mocked `triggerDragEnd` function to satisfy strict null checks. 💡 Why: Improves type safety in the test suite and removes linter bypasses, making the code more robust and aligned with project standards without altering runtime logic. ✅ Verification: Ran `npm run test` on the modified file to ensure tests pass, and `npm run lint` to verify no new warnings were introduced. Passed strict TypeScript compilation checks. ✨ Result: Clean, strictly typed test mocks with zero `any` usages or disabled linter warnings. Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com> --- .../__tests__/LayoutEditor.test.tsx | 37 ++++++++----------- 1 file changed, 16 insertions(+), 21 deletions(-) diff --git a/src/components/__tests__/LayoutEditor.test.tsx b/src/components/__tests__/LayoutEditor.test.tsx index fb53039..301a54f 100644 --- a/src/components/__tests__/LayoutEditor.test.tsx +++ b/src/components/__tests__/LayoutEditor.test.tsx @@ -4,6 +4,11 @@ import LayoutEditor from "../LayoutEditor"; import { CardLayout } from "@/lib/types"; import "@testing-library/jest-dom"; +interface MockWindow extends Window { + triggerDragEnd?: (event: unknown) => void; + mockIsOverId?: string; +} + // Mock dnd-kit components vi.mock("@dnd-kit/core", async (importOriginal) => { const actual = await importOriginal(); @@ -13,7 +18,7 @@ vi.mock("@dnd-kit/core", async (importOriginal) => {
{ // Expose a way to trigger onDragEnd via a synthetic event or global for testing // We'll attach it to window for easy triggering - (window as unknown as { triggerDragEnd: (event: unknown) => void }).triggerDragEnd = onDragEnd; + (window as unknown as MockWindow).triggerDragEnd = onDragEnd; }}> {children}
@@ -22,8 +27,7 @@ vi.mock("@dnd-kit/core", async (importOriginal) => { useSensor: vi.fn(() => ({})), useDroppable: ({ id }: { id: string }) => ({ setNodeRef: vi.fn(), - // eslint-disable-next-line @typescript-eslint/no-explicit-any - isOver: (window as any).mockIsOverId === id, + isOver: (window as unknown as MockWindow).mockIsOverId === id, }), PointerSensor: vi.fn(), KeyboardSensor: vi.fn(), @@ -64,10 +68,8 @@ describe("LayoutEditor", () => { beforeEach(() => { mockOnLayoutChange = vi.fn(); mockOnToggleVisibility = vi.fn(); - // eslint-disable-next-line @typescript-eslint/no-explicit-any - (window as any).triggerDragEnd = undefined; - // eslint-disable-next-line @typescript-eslint/no-explicit-any - (window as any).mockIsOverId = undefined; + (window as unknown as MockWindow).triggerDragEnd = undefined; + (window as unknown as MockWindow).mockIsOverId = undefined; }); it("renders blocks in their respective columns", () => { @@ -119,8 +121,7 @@ describe("LayoutEditor", () => { const dndContext = screen.getByTestId("dnd-context"); fireEvent.click(dndContext); - // eslint-disable-next-line @typescript-eslint/no-explicit-any - const triggerDragEnd = (window as any).triggerDragEnd; + const triggerDragEnd = (window as unknown as MockWindow).triggerDragEnd!; expect(triggerDragEnd).toBeDefined(); // Drag 'avatar' to 'right' column @@ -149,8 +150,7 @@ describe("LayoutEditor", () => { const dndContext = screen.getByTestId("dnd-context"); fireEvent.click(dndContext); - // eslint-disable-next-line @typescript-eslint/no-explicit-any - const triggerDragEnd = (window as any).triggerDragEnd; + const triggerDragEnd = (window as unknown as MockWindow).triggerDragEnd!; // Drag 'avatar' over 'topLanguages' triggerDragEnd({ @@ -178,8 +178,7 @@ describe("LayoutEditor", () => { const dndContext = screen.getByTestId("dnd-context"); fireEvent.click(dndContext); - // eslint-disable-next-line @typescript-eslint/no-explicit-any - const triggerDragEnd = (window as any).triggerDragEnd; + const triggerDragEnd = (window as unknown as MockWindow).triggerDragEnd!; triggerDragEnd({ active: { id: "avatar" }, over: null, @@ -200,8 +199,7 @@ describe("LayoutEditor", () => { const dndContext = screen.getByTestId("dnd-context"); fireEvent.click(dndContext); - // eslint-disable-next-line @typescript-eslint/no-explicit-any - const triggerDragEnd = (window as any).triggerDragEnd; + const triggerDragEnd = (window as unknown as MockWindow).triggerDragEnd!; triggerDragEnd({ active: { id: "avatar" }, over: { id: "avatar" }, @@ -222,8 +220,7 @@ describe("LayoutEditor", () => { const dndContext = screen.getByTestId("dnd-context"); fireEvent.click(dndContext); - // eslint-disable-next-line @typescript-eslint/no-explicit-any - const triggerDragEnd = (window as any).triggerDragEnd; + const triggerDragEnd = (window as unknown as MockWindow).triggerDragEnd!; triggerDragEnd({ active: { id: "avatar" }, over: { id: "non-existent-block" }, @@ -250,8 +247,7 @@ describe("LayoutEditor", () => { const dndContext = screen.getByTestId("dnd-context"); fireEvent.click(dndContext); - // eslint-disable-next-line @typescript-eslint/no-explicit-any - const triggerDragEnd = (window as any).triggerDragEnd; + const triggerDragEnd = (window as unknown as MockWindow).triggerDragEnd!; // Drag 'avatar' over 'stats' (downwards) triggerDragEnd({ @@ -278,8 +274,7 @@ describe("LayoutEditor", () => { const dndContext = screen.getByTestId("dnd-context"); fireEvent.click(dndContext); - // eslint-disable-next-line @typescript-eslint/no-explicit-any - const triggerDragEnd = (window as any).triggerDragEnd; + const triggerDragEnd = (window as unknown as MockWindow).triggerDragEnd!; // Drag 'avatar' to empty column 'right' triggerDragEnd({