From 9c4b07d0f2e47dbb3f9ca3658d2a0330898afccd Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Fri, 22 May 2026 07:00:55 +0000 Subject: [PATCH 1/2] refactor: remove any casts and eslint ignores in LayoutEditor tests Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com> --- .../__tests__/LayoutEditor.test.tsx | 38 +++++++++---------- 1 file changed, 17 insertions(+), 21 deletions(-) diff --git a/src/components/__tests__/LayoutEditor.test.tsx b/src/components/__tests__/LayoutEditor.test.tsx index fb53039..9a43197 100644 --- a/src/components/__tests__/LayoutEditor.test.tsx +++ b/src/components/__tests__/LayoutEditor.test.tsx @@ -4,6 +4,12 @@ import LayoutEditor from "../LayoutEditor"; import { CardLayout } from "@/lib/types"; import "@testing-library/jest-dom"; +interface WindowWithDragState extends Window { + triggerDragEnd?: (event: unknown) => void; + mockIsOverId?: string; +} + + // Mock dnd-kit components vi.mock("@dnd-kit/core", async (importOriginal) => { const actual = await importOriginal(); @@ -13,7 +19,7 @@ vi.mock("@dnd-kit/core", async (importOriginal) => {
{ // Expose a way to trigger onDragEnd via a synthetic event or global for testing // We'll attach it to window for easy triggering - (window as unknown as { triggerDragEnd: (event: unknown) => void }).triggerDragEnd = onDragEnd; + (window as unknown as WindowWithDragState).triggerDragEnd = onDragEnd; }}> {children}
@@ -22,8 +28,7 @@ vi.mock("@dnd-kit/core", async (importOriginal) => { useSensor: vi.fn(() => ({})), useDroppable: ({ id }: { id: string }) => ({ setNodeRef: vi.fn(), - // eslint-disable-next-line @typescript-eslint/no-explicit-any - isOver: (window as any).mockIsOverId === id, + isOver: (window as unknown as WindowWithDragState).mockIsOverId === id, }), PointerSensor: vi.fn(), KeyboardSensor: vi.fn(), @@ -64,10 +69,8 @@ describe("LayoutEditor", () => { beforeEach(() => { mockOnLayoutChange = vi.fn(); mockOnToggleVisibility = vi.fn(); - // eslint-disable-next-line @typescript-eslint/no-explicit-any - (window as any).triggerDragEnd = undefined; - // eslint-disable-next-line @typescript-eslint/no-explicit-any - (window as any).mockIsOverId = undefined; + (window as unknown as WindowWithDragState).triggerDragEnd = undefined; + (window as unknown as WindowWithDragState).mockIsOverId = undefined; }); it("renders blocks in their respective columns", () => { @@ -119,8 +122,7 @@ describe("LayoutEditor", () => { const dndContext = screen.getByTestId("dnd-context"); fireEvent.click(dndContext); - // eslint-disable-next-line @typescript-eslint/no-explicit-any - const triggerDragEnd = (window as any).triggerDragEnd; + const triggerDragEnd = (window as unknown as WindowWithDragState).triggerDragEnd; expect(triggerDragEnd).toBeDefined(); // Drag 'avatar' to 'right' column @@ -149,8 +151,7 @@ describe("LayoutEditor", () => { const dndContext = screen.getByTestId("dnd-context"); fireEvent.click(dndContext); - // eslint-disable-next-line @typescript-eslint/no-explicit-any - const triggerDragEnd = (window as any).triggerDragEnd; + const triggerDragEnd = (window as unknown as WindowWithDragState).triggerDragEnd; // Drag 'avatar' over 'topLanguages' triggerDragEnd({ @@ -178,8 +179,7 @@ describe("LayoutEditor", () => { const dndContext = screen.getByTestId("dnd-context"); fireEvent.click(dndContext); - // eslint-disable-next-line @typescript-eslint/no-explicit-any - const triggerDragEnd = (window as any).triggerDragEnd; + const triggerDragEnd = (window as unknown as WindowWithDragState).triggerDragEnd; triggerDragEnd({ active: { id: "avatar" }, over: null, @@ -200,8 +200,7 @@ describe("LayoutEditor", () => { const dndContext = screen.getByTestId("dnd-context"); fireEvent.click(dndContext); - // eslint-disable-next-line @typescript-eslint/no-explicit-any - const triggerDragEnd = (window as any).triggerDragEnd; + const triggerDragEnd = (window as unknown as WindowWithDragState).triggerDragEnd; triggerDragEnd({ active: { id: "avatar" }, over: { id: "avatar" }, @@ -222,8 +221,7 @@ describe("LayoutEditor", () => { const dndContext = screen.getByTestId("dnd-context"); fireEvent.click(dndContext); - // eslint-disable-next-line @typescript-eslint/no-explicit-any - const triggerDragEnd = (window as any).triggerDragEnd; + const triggerDragEnd = (window as unknown as WindowWithDragState).triggerDragEnd; triggerDragEnd({ active: { id: "avatar" }, over: { id: "non-existent-block" }, @@ -250,8 +248,7 @@ describe("LayoutEditor", () => { const dndContext = screen.getByTestId("dnd-context"); fireEvent.click(dndContext); - // eslint-disable-next-line @typescript-eslint/no-explicit-any - const triggerDragEnd = (window as any).triggerDragEnd; + const triggerDragEnd = (window as unknown as WindowWithDragState).triggerDragEnd; // Drag 'avatar' over 'stats' (downwards) triggerDragEnd({ @@ -278,8 +275,7 @@ describe("LayoutEditor", () => { const dndContext = screen.getByTestId("dnd-context"); fireEvent.click(dndContext); - // eslint-disable-next-line @typescript-eslint/no-explicit-any - const triggerDragEnd = (window as any).triggerDragEnd; + const triggerDragEnd = (window as unknown as WindowWithDragState).triggerDragEnd; // Drag 'avatar' to empty column 'right' triggerDragEnd({ From 5cabf36478c553deac740d3e801317140c27b88f Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Fri, 22 May 2026 07:10:41 +0000 Subject: [PATCH 2/2] refactor: remove any casts and eslint ignores in LayoutEditor tests Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com> --- src/components/__tests__/LayoutEditor.test.tsx | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/components/__tests__/LayoutEditor.test.tsx b/src/components/__tests__/LayoutEditor.test.tsx index 9a43197..b905f28 100644 --- a/src/components/__tests__/LayoutEditor.test.tsx +++ b/src/components/__tests__/LayoutEditor.test.tsx @@ -126,7 +126,7 @@ describe("LayoutEditor", () => { expect(triggerDragEnd).toBeDefined(); // Drag 'avatar' to 'right' column - triggerDragEnd({ + triggerDragEnd!({ active: { id: "avatar" }, over: { id: "right" }, }); @@ -154,7 +154,7 @@ describe("LayoutEditor", () => { const triggerDragEnd = (window as unknown as WindowWithDragState).triggerDragEnd; // Drag 'avatar' over 'topLanguages' - triggerDragEnd({ + triggerDragEnd!({ active: { id: "avatar" }, over: { id: "topLanguages" }, }); @@ -180,7 +180,7 @@ describe("LayoutEditor", () => { fireEvent.click(dndContext); const triggerDragEnd = (window as unknown as WindowWithDragState).triggerDragEnd; - triggerDragEnd({ + triggerDragEnd!({ active: { id: "avatar" }, over: null, }); @@ -201,7 +201,7 @@ describe("LayoutEditor", () => { fireEvent.click(dndContext); const triggerDragEnd = (window as unknown as WindowWithDragState).triggerDragEnd; - triggerDragEnd({ + triggerDragEnd!({ active: { id: "avatar" }, over: { id: "avatar" }, }); @@ -222,7 +222,7 @@ describe("LayoutEditor", () => { fireEvent.click(dndContext); const triggerDragEnd = (window as unknown as WindowWithDragState).triggerDragEnd; - triggerDragEnd({ + triggerDragEnd!({ active: { id: "avatar" }, over: { id: "non-existent-block" }, }); @@ -251,7 +251,7 @@ describe("LayoutEditor", () => { const triggerDragEnd = (window as unknown as WindowWithDragState).triggerDragEnd; // Drag 'avatar' over 'stats' (downwards) - triggerDragEnd({ + triggerDragEnd!({ active: { id: "avatar" }, over: { id: "stats" }, }); @@ -278,7 +278,7 @@ describe("LayoutEditor", () => { const triggerDragEnd = (window as unknown as WindowWithDragState).triggerDragEnd; // Drag 'avatar' to empty column 'right' - triggerDragEnd({ + triggerDragEnd!({ active: { id: "avatar" }, over: { id: "right" }, });