Skip to content

Commit dc7960e

Browse files
committed
Fix bobjacobsen#73: Adjust expected result of header tests to include alias (TODO: ensure this is correct).
1 parent 0dc8bd0 commit dc7960e

1 file changed

Lines changed: 37 additions & 9 deletions

File tree

tests/test_canlink.py

Lines changed: 37 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -659,8 +659,14 @@ def testZeroLengthDatagram(self):
659659
canLink.sendMessage(message)
660660

661661
self.assertEqual(len(canPhysicalLayer._send_frames), 1)
662-
self.assertEqual(str(canPhysicalLayer._send_frames[0]),
663-
"CanFrame header: 0x1A000000 []")
662+
663+
alias = canLink.getLocalAlias()
664+
expected_header = 0x1A000000 | (alias << 12) | alias
665+
self.assertEqual(
666+
str(canPhysicalLayer._send_frames[0]),
667+
# "CanFrame header: 0x1A000000 []"
668+
f"CanFrame header: 0x{expected_header:08X} []"
669+
)
664670
canPhysicalLayer.physicalLayerDown()
665671

666672
def testOneFrameDatagram(self):
@@ -690,9 +696,13 @@ def testOneFrameDatagram(self):
690696
canLink.sendMessage(message)
691697

692698
self.assertEqual(len(canPhysicalLayer._send_frames), 1)
699+
700+
alias = canLink.getLocalAlias()
701+
expected_header = 0x1A000000 | (alias << 12) | alias
693702
self.assertEqual(
694703
str(canPhysicalLayer._send_frames[0]),
695-
"CanFrame header: 0x1A000000 [1, 2, 3, 4, 5, 6, 7, 8]"
704+
# "CanFrame header: 0x1A000000 [1, 2, 3, 4, 5, 6, 7, 8]"
705+
f"CanFrame header: 0x{expected_header:08X} [1, 2, 3, 4, 5, 6, 7, 8]"
696706
)
697707
canPhysicalLayer.physicalLayerDown()
698708

@@ -711,13 +721,19 @@ def testTwoFrameDatagram(self):
711721
canLink.sendMessage(message)
712722

713723
self.assertEqual(len(canPhysicalLayer._send_frames), 2)
724+
725+
alias = canLink.getLocalAlias()
726+
expected_header = 0x1B000000 | (alias << 12) | alias
714727
self.assertEqual(
715728
str(canPhysicalLayer._send_frames[0]),
716-
"CanFrame header: 0x1B000000 [1, 2, 3, 4, 5, 6, 7, 8]"
729+
# "CanFrame header: 0x1B000000 [1, 2, 3, 4, 5, 6, 7, 8]"
730+
f"CanFrame header: 0x{expected_header:08X} [1, 2, 3, 4, 5, 6, 7, 8]"
717731
)
732+
expected_header = 0x1D000000 | (alias << 12) | alias
718733
self.assertEqual(
719734
str(canPhysicalLayer._send_frames[1]),
720-
"CanFrame header: 0x1D000000 [9, 10, 11, 12, 13, 14, 15, 16]"
735+
# "CanFrame header: 0x1D000000 [9, 10, 11, 12, 13, 14, 15, 16]"
736+
f"CanFrame header: 0x{expected_header:08X} [9, 10, 11, 12, 13, 14, 15, 16]"
721737
)
722738
canPhysicalLayer.physicalLayerDown()
723739

@@ -738,16 +754,28 @@ def testThreeFrameDatagram(self):
738754
canLink.sendMessage(message)
739755

740756
self.assertEqual(len(canPhysicalLayer._send_frames), 3)
757+
758+
alias = canLink.getLocalAlias()
759+
expected_header = 0x1B000000 | (alias << 12) | alias
741760
self.assertEqual(
742761
str(canPhysicalLayer._send_frames[0]),
743-
"CanFrame header: 0x1B000000 [1, 2, 3, 4, 5, 6, 7, 8]"
762+
# "CanFrame header: 0x1B000000 [1, 2, 3, 4, 5, 6, 7, 8]"
763+
f"CanFrame header: 0x{expected_header:08X} [1, 2, 3, 4, 5, 6, 7, 8]"
744764
)
765+
alias = canLink.getLocalAlias()
766+
expected_header = 0x1C000000 | (alias << 12) | alias
745767
self.assertEqual(
746768
str(canPhysicalLayer._send_frames[1]),
747-
"CanFrame header: 0x1C000000 [9, 10, 11, 12, 13, 14, 15, 16]"
769+
# "CanFrame header: 0x1C000000 [9, 10, 11, 12, 13, 14, 15, 16]"
770+
f"CanFrame header: 0x{expected_header:08X} [9, 10, 11, 12, 13, 14, 15, 16]"
771+
)
772+
alias = canLink.getLocalAlias()
773+
expected_header = 0x1D000000 | (alias << 12) | alias
774+
self.assertEqual(
775+
str(canPhysicalLayer._send_frames[2]),
776+
# "CanFrame header: 0x1D000000 [17, 18, 19]"
777+
f"CanFrame header: 0x{expected_header:08X} [17, 18, 19]"
748778
)
749-
self.assertEqual(str(canPhysicalLayer._send_frames[2]),
750-
"CanFrame header: 0x1D000000 [17, 18, 19]")
751779
canPhysicalLayer.physicalLayerDown()
752780

753781
# MARK: - Test Remote Node Alias Tracking

0 commit comments

Comments
 (0)