Merge pull request #126 from HelloPy-Korea/feature/image-upload-api

Feat: 이미지 업로드 API 수정

Author: jungmir

src/config/settings.py

@@ -137,6 +137,9 @@
     {"color": "hsl(231, 48%, 48%)", "label": "Indigo"},
     {"color": "hsl(207, 90%, 54%)", "label": "Blue"},
 ]
+
+CKEDITOR_5_UPLOAD_DIRECTORY_PREFIX = "editor/"
+CK_EDITOR_5_UPLOAD_FILE_VIEW_NAME = "custom_upload_file"
 CKEDITOR_5_CONFIGS = {
     "default": {
         "toolbar": {

src/config/urls.py

@@ -12,7 +12,7 @@
 
 urlpatterns = [
     path("admin/", admin.site.urls),
-    path("ckeditor5/", include("django_ckeditor_5.urls")),  # ckeditor5
+    path("api/public/", include("public.urls")),
     path("api/faqs/", include("faq.urls")),
     path("api/merchandise/", include("merchandise.urls")),
     path("api/notice/", include("notice.urls")),

src/core/storage.py

@@ -1,11 +1,15 @@
 import boto3
+from botocore.exceptions import ClientError
 from django.conf import settings
 
 
 def s3_delete_file(file_name: str) -> None:
-    storage = boto3.client(
-        "s3",
-        aws_access_key_id=settings.AWS_ACCESS_KEY_ID,
-        aws_secret_access_key=settings.AWS_SECRET_ACCESS_KEY,
-    )
-    storage.delete_object(Bucket=settings.AWS_STORAGE_BUCKET_NAME, Key=file_name)
+    try:
+        storage = boto3.client(
+            "s3",
+            aws_access_key_id=settings.AWS_ACCESS_KEY_ID,
+            aws_secret_access_key=settings.AWS_SECRET_ACCESS_KEY,
+        )
+        storage.delete_object(Bucket=settings.AWS_STORAGE_BUCKET_NAME, Key=file_name)
+    except ClientError as e:
+        print(f"Failed to delete {file_name} from S3: {e}")

src/notice/apps.py

@@ -4,3 +4,6 @@
 class NoticeConfig(AppConfig):
     default_auto_field = "django.db.models.BigAutoField"
     name = "notice"
+
+    def ready(self) -> None:
+        import notice.signals  # noqa: F401

src/notice/signals.py

@@ -0,0 +1,61 @@
+from django.conf import settings
+from django.core.exceptions import ValidationError
+from django.db.models.signals import post_save, pre_delete, pre_save
+from django.dispatch import receiver
+from django_ckeditor_5.signals import extract_image_paths
+
+from core.storage import s3_delete_file
+from notice.models import Notice
+from public.image_models import TemporaryImage
+
+
+@receiver(post_save, sender=Notice)
+def delete_temporary_images_on_notice_save(sender, instance, **kwargs):
+    images_to_delete = extract_image_paths(instance.content)
+
+    try:
+        for img_path in images_to_delete:
+            file_path = img_path.removeprefix(f"https://{settings.AWS_S3_CUSTOM_DOMAIN}/")
+            delete_images = TemporaryImage.objects.filter(path=file_path).all()
+            for image in delete_images:
+                image.soft_delete()
+    except Exception as e:
+        raise ValidationError(f"이미지 삭제 오류: {e}")
+
+
+@receiver(pre_save, sender=Notice)
+def cleanup_unused_ckeditor_images_on_update(sender, instance, **kwargs):
+    """
+    Removes unused images when an object is updated.
+    If any unexpected error occurs, it will be logged, but the deletion process won't break the update.
+    """
+    try:
+        try:
+            old_instance = sender.objects.get(pk=instance.pk)
+            old_images = set(extract_image_paths(old_instance.content))
+        except sender.DoesNotExist:
+            old_images = set()
+
+        new_images = set(extract_image_paths(instance.content))
+        unused_images = old_images - new_images
+
+        for image in unused_images:
+            # CKEditor5Field의 이미지 경로는 상대 경로이므로, 절대 경로로 변환
+            file_path = image.removeprefix(f"https://{settings.AWS_S3_CUSTOM_DOMAIN}/")
+            s3_delete_file(file_path)
+    except Exception as e:
+        print(f"Error in cleanup_unused_ckeditor_images_on_update: {e}")
+
+
+@receiver(pre_delete, sender=Notice)
+def cleanup_ckeditor_images_on_delete(sender, instance, **kwargs):
+    """
+    Removes images from disk when an object is deleted.
+    If an error occurs, it is logged, but the deletion process continues.
+    """
+    try:
+        for image in extract_image_paths(instance.content):
+            file_path = image.removeprefix(f"https://{settings.AWS_S3_CUSTOM_DOMAIN}/")
+            s3_delete_file(file_path)
+    except Exception as e:
+        print(f"Error in cleanup_ckeditor_images_on_delete: {e}")

src/public/__init__.py

@@ -1,5 +1,6 @@
 from django.contrib import admin
 
+from .image_models import TemporaryImage
 from .tag_models import Tag
 
 
@@ -9,3 +10,22 @@ class TagAdmin(admin.ModelAdmin):
 
     list_display = ("id", "name")
     search_fields = ("name",)
+
+
+@admin.register(TemporaryImage)
+class TemporaryImageAdmin(admin.ModelAdmin):
+    """임시 이미지 관리자 페이지"""
+
+    list_display = ("id", "path", "expiry_at")
+    search_fields = ("path",)
+
+    def has_add_permission(self, request):
+        return False  # 추가 비활성화
+
+    def has_change_permission(self, request, obj=None):
+        return False  # 수정 비활성화
+
+    def delete_queryset(self, request, queryset):
+        # Admin에서 여러 객체 삭제 시 호출됨
+        for obj in queryset:
+            obj.delete()

src/public/admin.py

@@ -0,0 +1,30 @@
+from datetime import timedelta
+
+from django.db import models
+
+from core.storage import s3_delete_file
+
+
+class TemporaryImage(models.Model):
+    path = models.CharField("임시 저장된 이미지 경로", max_length=255)
+    created_at = models.DateTimeField("임시 저장 일시", auto_now_add=True)
+    expiry_at = models.DateTimeField(
+        "만료 일시",
+        db_default=models.functions.TruncDate(
+            models.functions.Now() + timedelta(days=1), output_field=models.DateField()
+        ),
+    )
+
+    class Meta:
+        indexes = (models.Index(fields=["path"]),)
+        verbose_name = "임시 이미지"
+        verbose_name_plural = "임시 이미지들"
+
+    def delete(self, *args, **kwargs) -> None:
+        s3_delete_file(self.path)
+
+        super().delete(*args, **kwargs)
+
+    def soft_delete(self, *args, **kwargs) -> None:
+        """임시 이미지 삭제"""
+        super().delete(*args, **kwargs)

src/public/image_models.py

@@ -0,0 +1,51 @@
+# Generated by Django 5.2.3 on 2025-07-05 14:30
+
+import datetime
+
+import django.db.models.expressions
+import django.db.models.functions.datetime
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ("public", "0007_alter_noticetag_notice_action"),
+    ]
+
+    operations = [
+        migrations.CreateModel(
+            name="TemporaryImage",
+            fields=[
+                (
+                    "id",
+                    models.BigAutoField(
+                        auto_created=True, primary_key=True, serialize=False, verbose_name="ID"
+                    ),
+                ),
+                ("path", models.CharField(max_length=255, verbose_name="임시 저장된 이미지 경로")),
+                (
+                    "created_at",
+                    models.DateTimeField(auto_now_add=True, verbose_name="임시 저장 일시"),
+                ),
+                (
+                    "expiry_at",
+                    models.DateTimeField(
+                        db_default=django.db.models.functions.datetime.TruncDate(
+                            django.db.models.expressions.CombinedExpression(
+                                django.db.models.functions.datetime.Now(),
+                                "+",
+                                models.Value(datetime.timedelta(days=1)),
+                            ),
+                            output_field=models.DateField(),
+                        ),
+                        verbose_name="만료 일시",
+                    ),
+                ),
+            ],
+            options={
+                "verbose_name": "임시 이미지",
+                "verbose_name_plural": "임시 이미지들",
+                "indexes": [models.Index(fields=["path"], name="public_temp_path_a3ab43_idx")],
+            },
+        ),
+    ]

src/public/migrations/0008_temporaryimage.py

@@ -0,0 +1,8 @@
+from django.urls import path
+
+from .views import upload_file
+
+urlpatterns = [
+    # Custom upload file endpoint
+    path("custom_upload_file/", upload_file, name="custom_upload_file"),
+]