Merge pull request #41 from HellPat/better-reloads

tests with recursion

Author: HellPat

.github/workflows/main.yaml

@@ -72,13 +72,7 @@ jobs:
         shell: bash
         run: |
           echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV
-      - uses: actions/cache@v4
-        name: Setup pnpm cache
-        with:
-          path: ${{ env.STORE_PATH }}
-          key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
-          restore-keys: |
-            ${{ runner.os }}-pnpm-store-
+      # TODO: add cache for node_modules
       - name: Install dependencies
         run: pnpm install --frozen-lockfile --strict-peer-dependencies
       - shell: nix-shell --pure --run "bash -euxo pipefail {0}"

Procfile

@@ -7,7 +7,7 @@ symfony: rr serve -p -c .rr.dev.yaml --debug
 # TODO: rethink limits and restarts.
 #       I set a time limit and a limit of jobs to process, to easy using xdebug.
 #       Xdebug listening must be started in the IDE, and the long running process must be restarted to take effect.
-symfony-message-consumer: symfony run --watch=config,src,vendor bin/console messenger:consume async --limit=10 --time-limit=300 --no-interaction -vv
+symfony-message-consumer: bin/console messenger:consume async --limit=100 --time-limit=3000 --no-interaction -vv
 
 stripe: stripe listen --skip-verify --forward-to localhost:8000/webhook/stripe
 tailwindcss: tailwindcss -i assets/styles/app.css -o assets/styles/app.tailwind.css --watch

cypress/e2e/todo.cy.js cypress/e2e/customer.cy.jscypress/e2e/todo.cy.js renamed to cypress/e2e/customer.cy.js

@@ -1,6 +1,7 @@
 /// <reference types="cypress" />
 import Stripe from 'stripe';
 import { ulid } from 'ulid';
+import 'cypress-recurse/commands'
 
 // TODO: move to environment variable
 // set your api key with an environment variable `CYPRESS_API_KEY` or configure using `env` property in config file
@@ -21,18 +22,23 @@ describe('customers', () => {
 
   it('it adds new stripe users to the list', async () => {
     const email = `customer-${ulid()}@e2e.com`;
-    const customer = (await stripe.customers.create({
+    await stripe.customers.create({
       email: email,
-    }))
-    
-    const id = customer.id;
+    })
 
-    // TODO: retry the reload until it's there
-    //       waiting is bad, as it slows down the tests
-    cy.wait(5000)
-    cy.reload()
-
-    // check if the email address is visible in the list of customers
-    cy.get('[data-test="customer.list"] tbody > tr').contains(email)
+    cy.recurse(
+        () => cy.get(`[data-test-customer-email="${email}"]`).should(Cypress._.noop),
+        (el) => {
+            return el && el.text() === email
+        },
+        {
+            limit: 10,
+            delay: 2000, // sleep for 2 second before reloading the page
+            timeout: 60000, // retry for 60 seconds
+            post: () => {
+                cy.reload()
+            },
+        },
+    )
   })
 })

package.json

@@ -2,6 +2,7 @@
 	"packageManager": "pnpm@8.14.3",
 	"devDependencies": {
 		"cypress": "^13.6.3",
+		"cypress-recurse": "^1.35.2",
 		"stripe": "^14.13.0",
 		"ulid": "^2.3.0"
 	}

pnpm-lock.yaml

@@ -52,6 +52,7 @@ pkgs.mkShell {
     ];
 
     shellHook = ''
+        export OVERMIND_AUTO_RESTART=all
         export MYSQL_HOME=''${PWD}/storage/mysql
         export MYSQL_DATADIR=''${PWD}/storage/mysql/data
         export MYSQL_UNIX_PORT=''${PWD}/.mysql.sock

shell.nix

@@ -3,7 +3,7 @@
 {% block main %}
     <h1>Customers</h1>
 
-    <table data-test="customer.list">
+    <table>
         <thead>
                 <tr>
                     <th>id</th>
@@ -16,7 +16,7 @@
             {% for customer in customers %}
                 <tr>
                     <td>{{ customer.id }}</td>
-                    <td>{{ customer.email }}</td>
+                    <td data-test-customer-email="{{ customer.email }}">{{ customer.email }}</td>
                     <td>{{ customer.name }}</td>
                     <td>{{ customer.createdAt|date }}</td>
                 </tr>