Skip to content

multi-parameter inputs to CLI #173

@g-pechorin

Description

@g-pechorin

Is this the right issue type?

  • Yes, I'm planning work for this project team.

Summary

the dependency injection approaches use a long "connection string" like this ...

text = "minio:minio_user_c91f6832f2d525dd:minio_pass_ea1b5ab58c2bc631@http://127.0.0.1:58384/test-bucket-bae51f90a75dddab"

... we want the CLI to accept these in parts like this ...

assert obj._user == "minio_user_c91f6832f2d525dd"
assert obj._pass == "minio_pass_ea1b5ab58c2bc631"
assert obj._protocol == "http"
assert obj._host == "127.0.0.1"
assert obj._port == "58384"
assert obj._bucket == "test-bucket-bae51f90a75dddab"
assert obj._folder == ""  # (empty in this case)

... so this issue would probably be to change the OutputTargetArgumentType and SourceObjectArgumentType to read the components and produce that value.

(Click args can see a map of the strings passed to other args)

This might need special handling to check with ENVVARs and with specifying that first minio: or trino: protocol part.

Acceptance Criteria

  • update argument parsers to handle the changed approach
  • update tests to pass data as above
  • be sure passing new things by both CLI and environment variables works

Confirm creation

  • Ready to create this feature?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    Status

    In Progress

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions