logic understanding for ActorLockerManager

[chanokin]

Hi,

Sorry if this is a silly question but my compiler complained about having an OR next to an AND in this line:

ActorLocker/Source/ActorLocker/Private/ActorLockerManager.cpp

Line 377 in 1668436

if (!Widget.IsValid() || Widget->GetType() != TEXT("SSceneOutlinerTreeRow") && Widget->GetType() != TEXT("SSceneOutlinerTreeView"))

I'm not an Unreal developer, I'm just helping a friend figure this out. Is the logic here the AND should be evaluated before the OR?

 if (
     !Widget.IsValid() || 
     (Widget->GetType() != TEXT("SSceneOutlinerTreeRow") && Widget->GetType() != TEXT("SSceneOutlinerTreeView"))
) 

Thanks in advance!

[BlacRyu]

C++ naturally evaluates ==/!= before && and && before ||, so your revision should be logically equivalent. I think the compiler just recommends being explicit with parenthesis to improve readability and avoid logic errors where you might expect the || to evaluate before the &&.