fix(#2664): move away from Date value within the calendar/datepicker

Since time is never wanted when selecting dates it only adds to
complexity and adds issues regarding timezones. These changes replace
the Date with a custom type and minimizes the use of the Date type to
prevent breaking the current component binding.

Author: chrisolsen

libs/angular-components/src/lib/components/date-picker/date-picker.ts

@@ -55,7 +55,6 @@ import { GoabControlValueAccessor } from "../base.component";
 export class GoabDatePicker extends GoabControlValueAccessor implements OnInit {
   isReady = false;
   @Input() name?: string;
-  // ** NOTE: can we just use the base component for this?
   @Input() override value?: Date | string | null | undefined;
   @Input() min?: Date | string;
   @Input() max?: Date | string;
@@ -100,6 +99,12 @@ export class GoabDatePicker extends GoabControlValueAccessor implements OnInit {
       this.isReady = true;
       this.cdr.detectChanges();
     }, 0);
+
+    if (this.value && typeof this.value !== "string") {
+      console.warn(
+        "Using a `Date` type for value is deprecated. Instead use a string of the format `yyyy-mm-dd`",
+      );
+    }
   }
 
   override setDisabledState(isDisabled: boolean) {
@@ -120,7 +125,11 @@ export class GoabDatePicker extends GoabControlValueAccessor implements OnInit {
       if (!value) {
         this.renderer.setAttribute(datePickerEl, "value", "");
       } else {
-        this.renderer.setAttribute(datePickerEl, "value", value instanceof Date ? value.toISOString() : value);
+        this.renderer.setAttribute(
+          datePickerEl,
+          "value",
+          value instanceof Date ? value.toISOString() : value,
+        );
       }
     }
   }

libs/common/src/lib/common.ts

@@ -28,7 +28,7 @@ export type GoabInputOnFocusDetail<T = string> = GoabInputOnChangeDetail<T>;
 
 export type GoabMenuButtonOnActionDetail = {
   action: string;
-}
+};
 
 export type GoabInputAutoCapitalize =
   | "on"
@@ -70,7 +70,11 @@ export type GoabDropdownOnChangeDetail = {
 
 export type GoabDatePickerOnChangeDetail = {
   name?: string;
-  value: string | Date | undefined;
+  valueStr: string;
+  /**
+   * @deprecated Use `valueStr` instead
+   */
+  value: Date;
 };
 export type GoabDatePickerInputType = "calendar" | "input";
 
@@ -1158,7 +1162,6 @@ export type GoabPublicFormStatus = "initializing" | "complete";
 export type GoabPublicFormPageStep = "step" | "summary" | "multistep";
 export type GoabPublicFormPageButtonVisibility = "visible" | "hidden";
 
-
 // Public form Task
 export type GoabPublicFormTaskStatus = "completed" | "not-started" | "cannot-start";