[Bug Report] Special Characters in Filenames

[U2EZNeko]

Zotify Version
API dev branch, current live branch affected aswell

Bug Description
Bad encodings of special characters.

Bug Triggering Command

zotify https://open.spotify.com/intl-de/artist/4OBJLual30L7gRl5UkeRcT (T.I.)

Will create the Artist Folder as T.I_
Another Artist would be *NSYNC

This happens for albums aswell.

Config File
Defaults + custom regex.

Additional Context
Causes duplicates if an album/arist already exists with the correct folder namings. Spotdl used to do it perfectly so now when i run Zotify on the same artist or album it'll cause a dupe.

Is this something you can fix easily? Otherwise I'll just have to deal with it.

If needed I can get you more affected artists/albums when im home.

Love, Neko.

[Googolplexed0]

(T.I.) will create the Artist Folder as T.I_
Another Artist would be *NSYNC

This is the result of the fix_filename() function. Directories cannot contain a trailing . and invalid characters like /\:|<>"?* are all replaced with _. Although there are differences between what characters are allowed across different platforms (Windows vs Mac vs Linux), currently fix_filename() behaves the same across all platforms. This means it may make replacements on one platform that are not strictly necessary because they would be necessary for another platform.

Not high on my list of changes, since consistency across platforms is nice and this is only noticeable when comparing this library's output against the output of another. If you have a suggestion for a change (and rigorously test it) I would consider implementing it.

[U2EZNeko]

The problem mainly shows because my library was started with spotdl which handled special characters just fine.

I'll have a peek around the fix_filename() function, maybe i can find a solution for windows. No promises tho i suck with complex coding lel

[Phlogi]

https://github.com/spotDL/spotify-downloader/blob/e5c6f4567ae6f9fcaf083816363b0768c91e56e2/spotdl/utils/formatter.py#L502