[Feature Request] Support New Lossless Audio Quality

[treysu]

Related Problem/Issue
Is this Feature Request related to an existing GitHub Issue or Bug Report?
No. This could potentially already be an implemented feature, as I do not have access to lossless yet via Spotify.

Ideal Solution
Support downloading 24-bit/44.1 kHz FLAC files from Spotify

Considered Alternatives
None.

Additional context
Spotify Premium: Now Streaming in Lossless Quality

[Googolplexed0]

I will be looking into this as more details are released. This would be a huge upgrade.

[seathebeauty]

New to this space... But would this be the same as being able to download flac files from the original Zotify? Or was Zotify just converting from whatever lossy format Spotify gave into a flac when I chose flac as the output type?

[Googolplexed0]

when I chose flac as the output type

As far as I am aware, neither the original project nor this fork have ever supported or allowed upconverting from the api-supplied Vorbis codec to .flac (or any lossless codec). See the README for supported codecs/containers.

[NickDegrasse]

New to this space... But would this be the same as being able to download flac files from the original Zotify? Or was Zotify just converting from whatever lossy format Spotify gave into a flac when I chose flac as the output type?

It was the latter case - until a few weeks ago, the only codec spotify offered was lossy .ogg/vorbis encoding, which zotify would transcode to whichever format the user selected (as far as I know). Once lossless is supported with zotify, there'll be true lossless audio files available

[seathebeauty]

New to this space... But would this be the same as being able to download flac files from the original Zotify? Or was Zotify just converting from whatever lossy format Spotify gave into a flac when I chose flac as the output type?

It was the latter case - until a few weeks ago, the only codec spotify offered was lossy .ogg/vorbis encoding, which zotify would transcode to whichever format the user selected (as far as I know). Once lossless is supported with zotify, there'll be true lossless audio files available

Ok, phew, so I'm not crazy. In early August I was downloading from the original Zotify with zotify -lt --audio-format flac and actually getting flies ending in .flac but then when I switched over to this fork was wondering why it failed. Thanks for the background info.

I swear the orginal Zotify also used to show flac in the --help info but maybe I imagined it because it no longer shows in the github documentation.

[Googolplexed0]

Some more digging into this reveals the need for major modifications to the AudioFile.Format portion of librespot's metadata.proto (and compiling the changes to librespot.proto.Metadata_pb2.py). It would also require changes to the AudioQualty enum, a new LosslessOnlyAudioQuality class, and lots of troubleshooting/testing.

If someone already has protobuf experience then I would appreciate their insight. Otherwise, the lossless audio feature may be unlikely to arrive soon.

[acorness]

Some more digging into this reveals the need for major modifications to the AudioFile.Format portion of librespot's metadata.proto (and compiling the changes to librespot.proto.Metadata_pb2.py). It would also require changes to the AudioQualty enum, a new LosslessOnlyAudioQuality class, and lots of troubleshooting/testing.

If someone already has protobuf experience then I would appreciate their insight. Otherwise, the lossless audio feature may be unlikely to arrive soon.

He added support 3 days ago so it should be pretty straightforward now.

[losbe]

How to configure to download flac and how to update zotify

[Googolplexed0]

He added support 3 days ago so it should be pretty straightforward now.

I have already implemented it for testing but it is not working properly. The protobuf API is only fetching non-lossless tracks as far as I can tell. Will do some more digging and testing, but most of the work on my end is complete.