-
Notifications
You must be signed in to change notification settings - Fork 6.6k
chore(deps): update apache/beam_python3.9_sdk docker tag to v2.69.0 #13646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(deps): update apache/beam_python3.9_sdk docker tag to v2.69.0 #13646
Conversation
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the version of the Apache Beam Python 3.9 SDK Docker image used in custom container definitions for Dataflow. By bumping the SDK version, the pipelines leveraging these custom containers will benefit from the latest features, bug fixes, and performance improvements available in the newer Beam release. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the apache/beam_python3.9_sdk Docker image tag from 2.55.1 to 2.69.0 in the Dockerfiles for the miniconda and minimal custom container examples. While this is a good update, it introduces a version mismatch with the apache-beam Python package specified in the corresponding requirements.txt files, which remain at version 2.37.0. To ensure compatibility and prevent potential runtime issues, it's crucial to update the apache-beam dependency to match the new base image version (2.69.0).
|
|
||
| # Set the entrypoint to Apache Beam SDK worker launcher. | ||
| COPY --from=apache/beam_python3.9_sdk:2.55.1 /opt/apache/beam /opt/apache/beam | ||
| COPY --from=apache/beam_python3.9_sdk:2.69.0 /opt/apache/beam /opt/apache/beam |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While updating the Beam SDK base image to version 2.69.0, the corresponding apache-beam dependency in dataflow/custom-containers/miniconda/requirements.txt was not updated. It is currently pinned to 2.37.0.
A mismatch between the SDK version in the container and the version used to run the pipeline can lead to runtime errors. It's highly recommended to keep these versions in sync.
Please update dataflow/custom-containers/miniconda/requirements.txt to:
apache-beam[gcp]==2.69.0
|
|
||
| # Set the entrypoint to Apache Beam SDK worker launcher. | ||
| COPY --from=apache/beam_python3.9_sdk:2.55.1 /opt/apache/beam /opt/apache/beam | ||
| COPY --from=apache/beam_python3.9_sdk:2.69.0 /opt/apache/beam /opt/apache/beam |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Beam SDK base image is being updated to 2.69.0, but the apache-beam dependency in dataflow/custom-containers/minimal/requirements.txt is still at version 2.37.0.
To prevent potential runtime incompatibilities, it's important that the apache-beam package version matches the base image version.
Please update dataflow/custom-containers/minimal/requirements.txt to:
apache-beam[gcp]==2.69.0
This PR contains the following updates:
2.55.1->2.69.0Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Configuration
📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM, on day 1 of the month ( * 0-3 1 * * ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.