Skip to content

Commit 7534737

Browse files
committed
Finished setting config for gemma sample. it's now working
1 parent ba30940 commit 7534737

4 files changed

Lines changed: 11 additions & 7 deletions

File tree

dataflow/gemma/e2e_test.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
3535
OPTION B: Run tests with nox
3636
pip install nox
37-
nox -s py-3.10
37+
nox -s py-3.11
3838
3939
NOTE: For the tests to find the conftest in the testing infrastructure,
4040
add the PYTHONPATH to the "env" in your noxfile_config.py file.
@@ -47,8 +47,11 @@
4747

4848
import pytest
4949

50-
DATAFLOW_MACHINE_TYPE = "g2-standard-4"
51-
GEMMA_GCS = "gs://perm-dataflow-gemma-example-testdata/gemma_2b"
50+
DATAFLOW_MACHINE_TYPE = "g2-standard-8"
51+
# TODO If testing locally, point this to a bucket you control
52+
# and download the gemma assets
53+
# GEMMA_GCS = "gs://perm-dataflow-gemma-example-testdata/gemma_2b"
54+
GEMMA_GCS = "gs://test-bucket-for-gemma/assets_here/gemma_2b"
5255
NAME = "dataflow/gemma/streaming"
5356

5457

@@ -111,6 +114,7 @@ def dataflow_job(
111114
f"--temp_location=gs://{bucket_name}/temp",
112115
f"--region={location}",
113116
f"--machine_type={DATAFLOW_MACHINE_TYPE}",
117+
"--disk_size_gb=100",
114118
f"--sdk_container_image=gcr.io/{project}/{container_image}",
115119
"--dataflow_service_options=worker_accelerator=type:nvidia-l4;count:1;install-nvidia-driver:5xx",
116120
"--requirements_cache=skip",

dataflow/gemma/noxfile_config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,6 @@
1919
# The Python version used is defined by the Dockerfile and the job
2020
# submission enviornment must match.
2121
# Note: Docker-based sample, testing only against version specified in Dockerfile (3.11)
22-
"ignored_versions": ["3.8", "3.9", "3.10"],
22+
"ignored_versions": ["3.8", "3.9", "3.10", "3.12", "3.13", "3.14"],
2323
"envs": {"PYTHONPATH": ".."},
2424
}
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
google-cloud-aiplatform==1.157.0
1+
google-cloud-aiplatform==1.158.0
22
google-cloud-dataflow-client==0.14.0
33
google-cloud-storage==3.12.0
44
pytest==9.0.3
5-
pytest-timeout==2.4.0
5+
pytest-timeout==2.4.0

dataflow/gemma/requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ protobuf==6.33.6
22
apache_beam[gcp]==2.74.0
33
keras==3.14.1
44
keras_nlp==0.29.1
5-
pyOpenSSL==25.3.0
5+
pyOpenSSL==25.3.0

0 commit comments

Comments
 (0)