From 88f988452494b867d0865b9c09806c522325e48d Mon Sep 17 00:00:00 2001 From: Adam Ross Date: Tue, 23 Jun 2026 10:21:09 -0700 Subject: [PATCH 1/3] ci: Remove java 11 and java 17 CI from required checks --- .github/sync-repo-settings.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/sync-repo-settings.yaml b/.github/sync-repo-settings.yaml index ee480eb997c..c2dfd9cddc1 100644 --- a/.github/sync-repo-settings.yaml +++ b/.github/sync-repo-settings.yaml @@ -7,8 +7,6 @@ branchProtectionRules: requiredStatusCheckContexts: - 'cla/google' - 'header-check' - - 'Kokoro CI - Java 11' - - 'Kokoro CI - Java 17' - 'Kokoro CI - Lint' requiredApprovingReviewCount: 1 requiresCodeOwnerReviews: true From 22d7c22fa480b540f1cfac4823015a056b82717d Mon Sep 17 00:00:00 2001 From: Adam Ross Date: Tue, 23 Jun 2026 10:29:42 -0700 Subject: [PATCH 2/3] Update PULL_REQUEST_TEMPLATE.md: Streamline and require manual system testing --- .github/PULL_REQUEST_TEMPLATE.md | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 4ee98eb7f77..cbc450cd79a 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -2,18 +2,23 @@ Fixes # -Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google. - ## Checklist -- [ ] I have followed [Sample Format Guide](https://github.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md) -- [ ] `pom.xml` parent set to latest `shared-configuration` -- [ ] Appropriate changes to README are included in PR -- [ ] These samples need a new **API enabled** in testing projects to pass (let us know which ones) -- [ ] These samples need a new/updated **env vars** in testing projects set to pass (let us know which ones) +### Testing + +- [ ] **I have tested this change on a live environment and verified it works as intended.** - [ ] **Tests** pass: `mvn clean verify` **required** - [ ] **Lint** passes: `mvn -P lint checkstyle:check` **required** - [ ] **Static Analysis**: `mvn -P lint clean compile pmd:cpd-check spotbugs:check` **advisory only** + +### Compliance & Style + +- [ ] I have followed [Sample Format Guide](https://github.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md) +- [ ] `pom.xml` parent set to latest `shared-configuration` +- [ ] Appropriate changes to README are included in PR - [ ] This sample adds a new sample directory, and I updated the [CODEOWNERS file](https://github.com/GoogleCloudPlatform/java-docs-samples/blob/main/.github/CODEOWNERS) with the codeowners for this sample -- [ ] This sample adds a new **Product API**, and I updated the [Blunderbuss issue/PR auto-assigner](https://github.com/GoogleCloudPlatform/java-docs-samples/blob/main/.github/blunderbuss.yml) with the codeowners for this sample +- [ ] This sample adds a new **Product API**, and I updated the [Blunderbuss issue/PR auto-assigner](https://github.com/GoogleCloudPlatform/java-docs-samples/blob/main/.github/blunderbuss.yml) with the codeowners for this sample + +### Post-Approval Actions + - [ ] Please **merge** this PR for me once it is approved From e12b906dbe15f3ffce0ed7a61bc5657e2840ba7c Mon Sep 17 00:00:00 2001 From: Adam Ross Date: Tue, 23 Jun 2026 10:31:18 -0700 Subject: [PATCH 3/3] Update sync-repo-settings.yaml --- .github/sync-repo-settings.yaml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/sync-repo-settings.yaml b/.github/sync-repo-settings.yaml index c2dfd9cddc1..c6e15f9c4f8 100644 --- a/.github/sync-repo-settings.yaml +++ b/.github/sync-repo-settings.yaml @@ -14,9 +14,5 @@ branchProtectionRules: permissionRules: - team: java-samples-reviewers permission: push - - team: yoshi-java - permission: push - - team: yoshi-approver-team - permission: push - team: devrel-java-admin permission: admin