Skip to content

Conversation

@cfloress
Copy link

@cfloress cfloress commented Dec 5, 2025

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@cfloress cfloress requested review from a team and yoshi-approver as code owners December 5, 2025 03:13
@snippet-bot
Copy link

snippet-bot bot commented Dec 5, 2025

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 5, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @cfloress, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request expands the Google GenAI SDK's sample coverage by adding new Java examples for controlled generation. These samples illustrate how to guide the AI model to produce structured output using predefined schemas, including scenarios with simple class structures and more complex nested schemas involving enums. The addition of corresponding integration tests ensures the reliability of these new functionalities.

Highlights

  • New Controlled Generation Sample (Class Schema): Added a new Java sample demonstrating how to use a class-based schema for controlled generation with the Google GenAI SDK, specifically for generating structured recipe data.
  • New Controlled Generation Sample (Nested Schema): Introduced another Java sample showcasing controlled generation with a nested schema, including an enum type, to generate more complex structured data like recipes with ratings.
  • Integration Tests: Included new integration tests to validate the functionality and correctness of both the class-based and nested schema controlled generation samples.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds two new samples demonstrating controlled generation with class and nested schemas, which are great additions. The code is generally well-written, but I've identified a few areas for improvement. Specifically, there's a potential deserialization bug in the Grade enum that could cause runtime exceptions. I've also suggested some changes to align with standard Java naming conventions for better code maintainability. Please see my detailed comments below.

@gericdong gericdong added the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 5, 2025
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants