-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Adding Dataflow MDC Sample #10204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Adding Dataflow MDC Sample #10204
Conversation
Summary of ChangesHello @ebeltran-g, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Dataflow sample that demonstrates the use of Mapped Diagnostic Context (MDC) for enhanced logging within a Dataflow pipeline. The sample reads messages from a Pub/Sub subscription and uses MDC to include the message ID in log statements, providing a clearer context for each log entry. This new snippet will be used to update the public documentation, offering a practical and up-to-date reference for Dataflow users. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new Dataflow snippet demonstrating how to use Mapped Diagnostic Context (MDC) for enhanced logging. The example is clear and serves its purpose well. I've provided a few suggestions to improve the code's robustness, error handling, and adherence to best practices, particularly concerning character encoding, logging efficiency, exception management, and pipeline execution.
dataflow/snippets/src/main/java/com/example/dataflow/MdcSample.java
Outdated
Show resolved
Hide resolved
dataflow/snippets/src/main/java/com/example/dataflow/MdcSample.java
Outdated
Show resolved
Hide resolved
dataflow/snippets/src/main/java/com/example/dataflow/MdcSample.java
Outdated
Show resolved
Hide resolved
….java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
….java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
….java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Description
Adding a new Snippet code to use it as reference in the public doc. This will replace existing example which is only in the documentation
https://docs.cloud.google.com/dataflow/docs/guides/logging#df-integration
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only