fix: resolve CI lint failures blocking investigate-jsonschema-constraint branch#563
Merged
Merged
Conversation
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
…dispatch_test.go Agent-Logs-Url: https://github.com/GoCodeAlone/workflow/sessions/79fd7d0b-6586-494b-8f40-ee19def1afa9 Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Investigate additionalProperties enforcement in plugin SDK schema
fix: resolve CI lint failures blocking investigate-jsonschema-constraint branch
May 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR resolves two CI lint failures encountered while investigating stricter JSON Schema additionalProperties: false enforcement in the plugin SDK manifest schema, without changing runtime behavior.
Changes:
- Reworded two comments in the IaC codemod refactor to avoid gocritic’s
commentedOutCodefalse-positive ongenerates:(parsed as a Go label). - Removed duplicated
specs -> []string{name}logic in an infra provider dispatch test by reusing an existingspecNameshelper, eliminating anunusedlinter violation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cmd/iac-codemod/refactor_plan.go | Rephrases “generates:” comments to prose to avoid gocritic label parsing. |
| cmd/wfctl/infra_provider_dispatch_test.go | Uses specNames(specs) helper in both plan/apply seams to remove duplication and fix unused-helper linting. |
Contributor
|
@copilot resolve the merge conflicts in this pull request |
…sonschema-constraint # Conflicts: # cmd/iac-codemod/refactor_plan.go Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>
Contributor
Author
Merge conflicts resolved in |
Comment on lines
+251
to
252
| planCalls = append(planCalls, capturedPlanCall{provType: currentProvType, specNames: specNames(specs)}) | ||
| return interfaces.IaCPlan{}, nil |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surfaced during investigation of
additionalProperties: falseenforcement in the plugin SDK manifest schema (jsonschema/v6does honor the constraint — all regression tests inplugin/sdk/manifest_test.gopass). Two unrelated lint errors were blocking CI on this branch.Changes
cmd/iac-codemod/refactor_plan.go— Rephrased two// generates: <stmt>comments that gocritic'scommentedOutCodecheck was flagging:generates:is a valid Go label, making the comment parse as a labeled statement. Changed to prose descriptions.cmd/wfctl/infra_provider_dispatch_test.go— ThespecNameshelper was defined but never called; the plan-path and apply-path closures each inlined an equivalentmake/forloop. Replaced both inline loops withspecNames(specs), eliminating the duplication and satisfying theunusedlinter.