fix(wfctl): add missing cmd-build pipeline to wfctl.yaml#416
Closed
intel352 wants to merge 1 commit into
Closed
Conversation
wfctl build and all its subcommands (wfctl build image, wfctl build go, etc.) were routing through the CLI workflow engine but the corresponding cmd-build pipeline was absent from wfctl.yaml, causing: error: cli trigger: no pipeline registered for command "build" The fix adds the cmd-build pipeline following the same pattern as all other cmd-* pipelines (trigger: cli + step.cli_invoke delegate). Discovered while migrating buymywishlist to v0.14.1 wfctl build + ci init primitives. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the missing cmd-build CLI pipeline to wfctl.yaml so the already-registered wfctl build command is actually routable by the CLI trigger and no longer fails with “no pipeline registered”.
Changes:
- Added
pipelines.cmd-buildwired totrigger.type: cliwithcommand: build - Delegates execution to the existing Go implementation via
step.cli_invoke(consistent with othercmd-*pipelines)
Contributor
Author
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wfctl build(and all subcommands:wfctl build image,wfctl build go, etc.) fail witherror: cli trigger: no pipeline registered for command "build"because thecmd-buildpipeline was missing fromwfctl.yamlbuildcommand was correctly registered inmain.go'scommandsmap and listed in the wfctl.yaml command descriptions, but the correspondingcmd-build:workflow pipeline was absentcmd-build:following the identical pattern used by all othercmd-*pipelinesRoot Cause
Every wfctl command requires two registrations:
commandsmap inmain.go→ present forbuildcmd-<name>:pipeline inwfctl.yaml→ missing forbuildThe
cianddevcommands had their pipelines;builddid not.Test Plan
wfctl build --helpno longer errors with "no pipeline registered"WFCTL_BUILD_DRY_RUN=1 wfctl build image --config app.yamlprints the planneddocker buildcommandwfctl build --dry-run --config app.yamlruns the full build orchestration in dry-run modeDiscovered while migrating GoCodeAlone/buymywishlist to v0.14.1
wfctl build+wfctl ci initprimitives.🤖 Generated with Claude Code