-
Notifications
You must be signed in to change notification settings - Fork 1
Add status_from field to step.json_response for dynamic status codes #382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
174ecfb
Initial plan
Copilot 18f577d
Add status_from field to step.json_response for dynamic HTTP status c…
Copilot c4a2d65
Merge branch 'main' into copilot/add-status-from-field
intel352 1f8014c
Merge branch 'main' into copilot/add-status-from-field
intel352 feb1e97
Apply review feedback: validate status_from range, make status option…
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolveStatuscurrently convertsfloat64(andint64) tointvia a plain cast. This will silently truncate non-integer floats (e.g. 404.9 -> 404) and can allow out-of-range/invalid HTTP status codes to reachWriteHeader, which can cause runtime errors depending on the underlyingResponseWriter. Consider validating that the resolved value is an integer (no fractional part) and within the valid HTTP status code range before using it; otherwise fall back to the configured static status (or 200).