ci: canonical registry notify (fix dead dispatch + drop manifest-overwrite)#17
Merged
Merged
Conversation
Replaced the broken two-pronged registry notification approach with the fleet-canonical pattern: - REMOVED: direct manifest-write step that cloned workflow-registry, patched plugins/steam/manifest.json, and pushed via REGISTRY_PAT. This required an over-privileged PAT and raced with registry-side tooling that owns manifest content. - REMOVED: notify-registry job using peter-evans/repository-dispatch@v3 with full github.repository as plugin name and REGISTRY_PAT token — both wrong per fleet standard. - ADDED: notify-workflow-registry job using pinned peter-evans/repository-dispatch@28959ce (v4), secrets.repo_dispatch_token, bare plugin name "steam", and correct pre-release/deletion guards matching all fleet peers. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the release workflow to notify GoCodeAlone/workflow-registry using the fleet-canonical repository-dispatch pattern, removing the prior direct manifest-edit/PR flow and the broken dispatch job.
Changes:
- Removed the “Update registry manifest” step that cloned and modified
workflow-registryusing an elevated PAT. - Replaced the old
notify-registryjob withnotify-workflow-registry, using a pinnedpeter-evans/repository-dispatchv4 SHA. - Added guards to only dispatch on non-deleted, non-pre-release tags and only from the expected repository, with a “bare” plugin name payload (
steam).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the broken two-pronged registry notification with the fleet-canonical pattern.
Removed:
plugins/steam/manifest.jsonviaREGISTRY_PAT— over-privileged and races with registry-side toolingnotify-registryjob usingpeter-evans/repository-dispatch@v3with wrong token (REGISTRY_PAT), wrong plugin name (github.repositoryinstead of baresteam), and no pre-release/deletion guardsAdded:
notify-workflow-registryjob matching fleet standard: pinned@v4digest,secrets.repo_dispatch_token, bare name"steam", correct guards (!deleted, no pre-release hyphen, repo check)