chore: apply plugin version discipline#23
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enforces “version discipline” for the Discord Workflow plugin by keeping the committed manifest at a development sentinel version while adding CI validation to ensure the shipped (GoReleaser-staged) manifest is correctly stamped for releases.
Changes:
- Set
plugin.json.versionto the0.0.0development sentinel. - Add a post-build GitHub Actions step to validate the GoReleaser-staged manifest in
.goreleaser-tmpagainst the release tag. - Relax the download-matrix test to allow a sentinel manifest version while still checking archive naming.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
plugin.json |
Keeps the committed manifest at the 0.0.0 dev sentinel version. |
internal/plugin_test.go |
Updates the download-matrix test to tolerate sentinel versioning logic. |
.github/workflows/release.yml |
Adds post-build validation of the staged/shipped manifest in .goreleaser-tmp. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of GoCodeAlone/workflow#760.\n\nChanges:\n- keep committed plugin.json.version at the 0.0.0 development sentinel\n- add post-build release validation against the .goreleaser-tmp shipped manifest staging directory\n- update the download matrix test to allow the committed sentinel while preserving release artifact coverage\n\nVerification:\n- wfctl plugin validate-contract .\n- wfctl plugin validate-contract --for-publish --tag v9.9.9 .\n- GOWORK=off go test ./...