Skip to content

Commit 22e2ea2

Browse files
intel352claude
andauthored
fix: release workflow goreleaser --skip=validate — accept ui_dist drift at release time (#18)
v1.0.3 release run surfaced third bug after npm-auth + cp-cwd fixes landed: release failed after 0s error= git is in a dirty state M internal/ui_dist/index.html Root cause: Build-admin-UI step rebuilds internal/ui_dist/ from workflow repo HEAD (latest UI source), which may differ from this repo's committed snapshot (kept in-tree for go:embed at dev time). GoReleaser's git-dirty-state validation correctly flags this as 'modified files since last commit'. The fresh build IS the intended release artifact — we WANT the just-built dist embedded in the release binary, not the stale committed snapshot. So the dirty state is expected at release time. Fix: --skip=validate flag bypasses dirty check. Per goreleaser docs this is the appropriate escape hatch when build artifacts intentionally differ from committed state. Followup: cut v1.0.4 from main after this lands. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 2e26487 commit 22e2ea2

1 file changed

Lines changed: 9 additions & 1 deletion

File tree

.github/workflows/release.yml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,15 @@ jobs:
5555
- uses: goreleaser/goreleaser-action@v7
5656
with:
5757
version: '~> v2'
58-
args: release --clean
58+
# --skip=validate bypasses goreleaser's git-dirty-state check.
59+
# The Build admin UI step rebuilds internal/ui_dist/ from workflow
60+
# repo HEAD, which may differ from this repo's committed snapshot
61+
# (kept in-tree for go:embed at dev time). Per workflow-plugin-admin
62+
# #13 v1.0.3 release run failure, dirty check fired on
63+
# internal/ui_dist/index.html. The fresh build is the intended
64+
# release artifact; skip-validate accepts that ui_dist drift is
65+
# expected at release time.
66+
args: release --clean --skip=validate
5967
env:
6068
GITHUB_TOKEN: ${{ secrets.RELEASES_TOKEN }}
6169
GOPRIVATE: github.com/GoCodeAlone/*

0 commit comments

Comments
 (0)