Commit ffdfa4f
committed
fix(test-driven-development): address round-4 findings — graph labels, comment, emoji, type annotation
Finding 1+5 (Important/Minor): verify_green diamond had unlabeled third edge
causing ambiguity about when to exit to next vs verify_invariant. Labeled the
exit as 'done (post-refactor)' and first-pass edge as 'yes (first pass)'.
Added prose note in REFACTOR: invariant check applies once per bug fix, not
after each refactor cycle.
Finding 2 (Important): Comment 'New methods MUST include the same arg' overstated
the enforcement — the table only gates methods explicitly listed. Updated comment
to instruct maintainers to add a row when adding a new method.
Finding 3 (Minor): Emoji checkmarks (✓) in new-flow.md violated workspace
convention (no emoji without user request). Replaced with [confirmed: ...] text.
Finding 4 (Minor): spy.lastArgs type unspecified; map[string]any silently returns
wrong comparison without type assertion. Updated comment to specify map[string]string
or explicit type assertion.1 parent 70c4967 commit ffdfa4f
2 files changed
Lines changed: 10 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | | - | |
| 64 | + | |
65 | 65 | | |
| 66 | + | |
66 | 67 | | |
67 | 68 | | |
68 | 69 | | |
69 | | - | |
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
| |||
225 | 225 | | |
226 | 226 | | |
227 | 227 | | |
| 228 | + | |
| 229 | + | |
228 | 230 | | |
229 | 231 | | |
230 | 232 | | |
| |||
307 | 309 | | |
308 | 310 | | |
309 | 311 | | |
310 | | - | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
311 | 315 | | |
312 | 316 | | |
313 | 317 | | |
| |||
322 | 326 | | |
323 | 327 | | |
324 | 328 | | |
325 | | - | |
| 329 | + | |
326 | 330 | | |
327 | 331 | | |
328 | 332 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | | - | |
| 6 | + | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
0 commit comments