Skip to content

Commit b0ce92f

Browse files
author
Jon Langevin
committed
review: clarify finding-ID numbering (I1) + tighten D1<->D2 test assertion (M1)
1 parent c928fa6 commit b0ce92f

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

skills/adversarial-design-review/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ inherits the design's blast radius) and adds:
158158
**Findings (Minor):**
159159
- `D3` [class] [section/line]: <description>. Recommendation: <concrete fix>. _Resolution: <optional>._
160160

161-
Design-phase finding IDs are `D1, D2, …`; plan-phase `P1, P2, …`. IDs are the durable anchor `post-merge-retrospective` correlates against; the optional `Resolution` is a scoring hint (retro falls back to downstream evidence when omitted). Each finding has a **stable finding ID** as its first token.
161+
Design-phase finding IDs are `D1, D2, …`; plan-phase `P1, P2, …`, numbered **sequentially across all findings regardless of severity** (`D1` is the first finding overall, not the first Critical). IDs are the durable anchor `post-merge-retrospective` correlates against; the optional `Resolution` is a scoring hint (retro falls back to downstream evidence when omitted). Each finding has a **stable finding ID** as its first token.
162162

163163
**Bug-class scan transcript:**
164164
| Class | Result | Note |

tests/pipeline-evidence-doc-sync.sh

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,10 @@ has "$ADR" "Write AND commit the report" \
2424
hasE "$ADR" 'stable finding ID|stable .*ID' \
2525
&& pass "#69 ADR defines stable finding IDs" \
2626
|| bad "#69 ADR missing stable finding IDs"
27-
# P4: guard the load-bearing D1<->D2 path contract -- retro must cite the same derivation
28-
hasE "$RETRO" 'same deterministic rule|-plan-review\.md' \
27+
# P4/M1: guard the load-bearing D1<->D2 path contract -- retro must cite the SAME derivation.
28+
# Assert the specific load-bearing phrase only (dropping the broad '-plan-review.md' OR branch,
29+
# which is ambient vocabulary that could false-pass on an incidental path mention).
30+
has "$RETRO" "same deterministic rule" \
2931
&& pass "#69/#70 retro derives the report path by the same rule (D1<->D2 contract)" \
3032
|| bad "#69/#70 retro missing the shared path-derivation rule"
3133

0 commit comments

Comments
 (0)