Skip to content

Commit 22e52f9

Browse files
Merge pull request #200 from Srijatalamarla/fix/PR-closed-filter
fix: 'closed' filter behavior in PR section
2 parents cda5a3a + 9e90722 commit 22e52f9

1 file changed

Lines changed: 12 additions & 5 deletions

File tree

src/pages/Tracker/Tracker.tsx

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -101,11 +101,18 @@ const Home: React.FC = () => {
101101
const filterData = (data: GitHubItem[], filterType: string): GitHubItem[] => {
102102
let filtered = [...data];
103103
if (["open", "closed", "merged"].includes(filterType)) {
104-
filtered = filtered.filter((item) =>
105-
filterType === "merged"
106-
? !!item.pull_request?.merged_at
107-
: item.state === filterType
108-
);
104+
filtered = filtered.filter((item) => {
105+
if (filterType === "merged") {
106+
return !!item.pull_request?.merged_at
107+
}
108+
else if (filterType === "closed") {
109+
return item.state === "closed" && !item.pull_request?.merged_at
110+
}
111+
else {
112+
//open
113+
return item.state === "open"
114+
}
115+
});
109116
}
110117
if (searchTitle) {
111118
filtered = filtered.filter((item) =>

0 commit comments

Comments
 (0)