remove build related methods in projects api

Author: fbourigault

UPGRADE.md

@@ -30,6 +30,9 @@ Use the `deployKeys`, `deployKey`, `addDeployKey`, `deleteDeployKey`, `removeDep
 * The `ORDER_BY` and `SORT` class constants have been removed.
 * The `accessible`, `owned` and `search` methods have been removed. Use `all` method instead.
 * The `all` method now take a single argument which is an associative array of query string parameters.
+* The `trace` method have been removed. Use `Gitlab\Api\Jobs::trace` instead.
+* The `builds` method have been removed. Use `Gitlab\Api\Jobs::all` instead.
+* The `build` method have been removed. Use `Gitlab\Api\Jobs::show` instead.
 
 ## `Gitlab\Api\Repositories` changes
 

lib/Gitlab/Api/Projects.php

@@ -147,38 +147,6 @@ public function unarchive($project_id){
         return $this->post("projects/".$this->encodePath($project_id)."/unarchive");
     }
 
-    /**
-     * @param int $project_id
-     * @param array $scope
-     * @return mixed
-     */
-    public function builds($project_id, $scope = null)
-    {
-        return $this->get($this->getProjectPath($project_id, 'builds'), array(
-            'scope' => $scope
-        ));
-    }
-
-    /**
-     * @param int $project_id
-     * @param int $build_id
-     * @return mixed
-     */
-    public function build($project_id, $build_id)
-    {
-        return $this->get($this->getProjectPath($project_id, 'builds/'.$this->encodePath($build_id)));
-    }
-
-    /**
-     * @param int $project_id
-     * @param int $build_id
-     * @return mixed
-     */
-    public function trace($project_id, $build_id)
-    {
-        return $this->get($this->getProjectPath($project_id, 'builds/'.$this->encodePath($build_id).'/trace'));
-    }
-
     /**
      * @param int $project_id
      * @return mixed

test/Gitlab/Tests/Api/ProjectsTest.php

@@ -207,99 +207,6 @@ public function shouldRemoveProject()
         $this->assertEquals($expectedBool, $api->remove(1));
     }
 
-    /**
-     * @test
-     */
-    public function shouldGetBuilds()
-    {
-        $expectedArray = array(
-            array('id' => 1, 'status' => 'success'),
-            array('id' => 2, 'status' => 'failed')
-        );
-
-        $api = $this->getApiMock();
-        $api->expects($this->once())
-            ->method('get')
-            ->with('projects/1/builds')
-            ->will($this->returnValue($expectedArray))
-        ;
-
-        $this->assertEquals($expectedArray, $api->builds(1));
-    }
-
-    /**
-     * @test
-     */
-    public function shouldGetBuildsWithScope()
-    {
-        $expectedArray = array(
-            array('id' => 1, 'status' => 'success'),
-        );
-
-        $api = $this->getApiMock();
-        $api->expects($this->once())
-            ->method('get')
-            ->with('projects/1/builds', array('scope' => 'success'))
-            ->will($this->returnValue($expectedArray))
-        ;
-
-        $this->assertEquals($expectedArray, $api->builds(1, 'success'));
-    }
-
-    /**
-     * @test
-     */
-    public function shouldGetBuildsWithMultipleScopes()
-    {
-        $expectedArray = array(
-            array('id' => 1, 'status' => 'success'),
-            array('id' => 1, 'status' => 'failed'),
-        );
-
-        $api = $this->getApiMock();
-        $api->expects($this->once())
-            ->method('get')
-            ->with('projects/1/builds', array('scope' => array('success', 'failed')))
-            ->will($this->returnValue($expectedArray))
-        ;
-
-        $this->assertEquals($expectedArray, $api->builds(1, array('success', 'failed')));
-    }
-
-    /**
-     * @test
-     */
-    public function shouldGetBuild()
-    {
-        $expectedArray = array('id' => 2);
-
-        $api = $this->getApiMock();
-        $api->expects($this->once())
-            ->method('get')
-            ->with('projects/1/builds/2')
-            ->will($this->returnValue($expectedArray))
-        ;
-
-        $this->assertEquals($expectedArray, $api->build(1, 2));
-    }
-
-    /**
-     * @test
-     */
-    public function shouldGetTrace()
-    {
-        $expectedString = 'runner trace of a specific build';
-
-        $api = $this->getApiMock();
-        $api->expects($this->once())
-            ->method('get')
-            ->with('projects/1/builds/2/trace')
-            ->will($this->returnValue($expectedString))
-        ;
-
-        $this->assertEquals($expectedString, $api->trace(1, 2));
-    }
-
     /**
      * @test
      */