Merge pull request #215 from fbourigault/v4-api-9679

commits repository v4 api changes

Author: fbourigault

UPGRADE.md

@@ -18,6 +18,10 @@ See [documentation](doc/customize.md) to know how to customize the client timeou
 * The `keys`, `key`, `addKey`, `removeKey`, `disableKey` and `enableKey` methods have been removed.
 Use the `deployKeys`, `deployKey`, `addDeployKey`, `deleteDeployKey`, `removeDeployKey` and `enableDeployKey` instead.
 
+## `Gitlab\Api\Repositories` changes
+
+* The `commits` page argument now start from 1 instead of 0.
+
 ## `Gitlab\Model\Project` changes
 
 * The `keys`, `key`, `addKey`, `removeKey`, `disableKey` and `enableKey` methods have been removed.

lib/Gitlab/Api/Repositories.php

@@ -150,7 +150,7 @@ public function commitBuilds($project_id, $sha, $scope = null, $page = 0, $per_p
      * @param null $ref_name
      * @return mixed
      */
-    public function commits($project_id, $page = 0, $per_page = self::PER_PAGE, $ref_name = null)
+    public function commits($project_id, $page = 1, $per_page = self::PER_PAGE, $ref_name = null)
     {
         return $this->get($this->getProjectPath($project_id, 'repository/commits'), array(
             'page' => $page,

test/Gitlab/Tests/Api/RepositoriesTest.php

@@ -228,7 +228,7 @@ public function shouldGetCommits()
         $api = $this->getApiMock();
         $api->expects($this->once())
             ->method('get')
-            ->with('projects/1/repository/commits', array('page' => 0, 'per_page' => AbstractApi::PER_PAGE, 'ref_name' => null))
+            ->with('projects/1/repository/commits', array('page' => 1, 'per_page' => AbstractApi::PER_PAGE, 'ref_name' => null))
             ->will($this->returnValue($expectedArray))
         ;