Use OptionsResolver in Projects::deployments

Author: fbourigault

UPGRADE.md

@@ -58,6 +58,7 @@ Use the `deployKeys`, `deployKey`, `addDeployKey`, `deleteDeployKey`, `removeDep
 * The `builds` method have been removed. Use `Gitlab\Api\Jobs::all` instead.
 * The `build` method have been removed. Use `Gitlab\Api\Jobs::show` instead.
 * The `events` method second and subsequent arguments have been replaced by a single associative array of query string parameters.
+* The `deployments` method second and subsequent arguments have been replaced by a single associative array of query string parameters.
 
 ## `Gitlab\Api\ProjectNamespaces` changes
 

lib/Gitlab/Api/Projects.php

@@ -609,16 +609,15 @@ public function uploadFile($project_id, $file)
 
     /**
      * @param int $project_id
-     * @param int $page
-     * @param int $per_page
+     * @param array $parameters
+     *
      * @return mixed
      */
-    public function deployments($project_id, $page = 1, $per_page = self::PER_PAGE)
+    public function deployments($project_id, array $parameters = [])
     {
-        return $this->get($this->getProjectPath($project_id, 'deployments'), array(
-            'page' => $page,
-            'per_page' => $per_page
-        ));
+        $resolver = $this->createOptionsResolver();
+
+        return $this->get($this->getProjectPath($project_id, 'deployments'), $resolver->resolve($parameters));
     }
 
     /**

test/Gitlab/Tests/Api/ProjectsTest.php

@@ -930,10 +930,7 @@ public function shouldGetDeployments()
         $api = $this->getApiMock();
         $api->expects($this->once())
             ->method('get')
-            ->with('projects/1/deployments', array(
-                'page' => 1,
-                'per_page' => AbstractApi::PER_PAGE
-            ))
+            ->with('projects/1/deployments', array())
             ->will($this->returnValue($expectedArray))
         ;
 
@@ -960,7 +957,7 @@ public function shouldGetDeploymentsWithPagination()
             ->will($this->returnValue($expectedArray))
         ;
 
-        $this->assertEquals($expectedArray, $api->deployments(1, 2, 15));
+        $this->assertEquals($expectedArray, $api->deployments(1, ['page' => 2, 'per_page' => 15]));
     }
 
     protected function getMultipleProjectsData()