consistent menu styles (#2580)

Author: rnystrom

Classes/Labels/LabelMenuCell.swift

@@ -17,6 +17,7 @@ final class LabelMenuCell: SelectableCell {
     override init(frame: CGRect) {
         super.init(frame: frame)
 
+        overlayColor = Styles.Colors.Gray.medium.color
         backgroundColor = nil
         contentView.backgroundColor = nil
 

Classes/Milestones/MilestoneCell.swift

@@ -18,6 +18,7 @@ final class MilestoneCell2: SelectableCell {
     override init(frame: CGRect) {
         super.init(frame: frame)
 
+        overlayColor = Styles.Colors.Gray.medium.color
         backgroundColor = nil
         contentView.backgroundColor = nil
 

Classes/Notifications/Filter/InboxFilterRepoCell.swift

@@ -16,6 +16,7 @@ final class InboxFilterRepoCell: SelectableCell {
     override init(frame: CGRect) {
         super.init(frame: frame)
 
+        overlayColor = Styles.Colors.Gray.medium.color
         accessibilityIdentifier = "inbox-filter-repo-cell"
 
         label.adjustsFontSizeToFitWidth = true
@@ -28,7 +29,8 @@ final class InboxFilterRepoCell: SelectableCell {
             make.right.lessThanOrEqualTo(-Styles.Sizes.gutter)
         }
 
-        addBorder(.bottom, left: Styles.Sizes.gutter)
+        let border = contentView.addBorder(.bottom, left: Styles.Sizes.gutter, right: -Styles.Sizes.gutter)
+        border.backgroundColor = Styles.Colors.Gray.medium.color
     }
 
     required init?(coder aDecoder: NSCoder) {

Classes/People/PeopleCell.swift

@@ -19,6 +19,7 @@ final class PeopleCell: SelectableCell {
     override init(frame: CGRect) {
         super.init(frame: frame)
 
+        overlayColor = Styles.Colors.Gray.medium.color
         backgroundColor = nil
         contentView.backgroundColor = nil
 

Classes/Views/SelectableCell.swift

@@ -41,6 +41,11 @@ class SelectableCell: UICollectionViewCell {
         return self.contentView.addOverlay()
     }()
 
+    var overlayColor: UIColor? {
+        get { return overlay.backgroundColor }
+        set { overlay.backgroundColor = newValue }
+    }
+
     override init(frame: CGRect) {
         super.init(frame: frame)
         accessibilityTraits |= UIAccessibilityTraitButton