Upgrade/cms13#42
Conversation
update changelog and readme update relese.yml remove content-delivery-api.md Dropped Newtonsoft.Json entirely — consolidated on System.Text.Json .csproj file updated handling exceptions fixed
Upgrade to cms13 and aspire
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades the project to support Optimizely CMS 13 and .NET 10, removing obsolete dependencies like IVirtualPathResolver and Newtonsoft.Json in favor of System.Text.Json and manual DI registration patterns. It also replaces the Alloy sandbox with a new Geta.Optimizely.GenericLinks.Web test site. Feedback on the changes highlights a potential runtime casting issue in PropertyLinkBase.cs when casting the lazy factory delegate, suggesting a safer cast to Delegate with DynamicInvoke(). Additionally, minor performance improvements are recommended in NestedLinkBlockComponent and PropertyThumbnailTestBlockComponent to avoid unnecessary async/await state machine overhead when returning completed tasks.
2 participants
No description provided.