fix: ensure main client closes even if child close fails, add moderation test

Wrap child client closing in try/finally so super().aclose() always
runs. Use child.aclose() instead of child.client.aclose() to keep
close semantics encapsulated. Add test for moderation client closure.

Author: aliev

getstream/stream.py

@@ -209,11 +209,13 @@ def moderation(self) -> AsyncModerationClient:
 
     async def aclose(self):
         """Close all child clients and the main HTTPX client."""
-        for attr in ("video", "chat", "moderation"):
-            child = self.__dict__.get(attr)
-            if child is not None and hasattr(child, "client"):
-                await child.client.aclose()
-        await super().aclose()
+        try:
+            for attr in ("video", "chat", "moderation"):
+                child = self.__dict__.get(attr)
+                if child is not None and hasattr(child, "aclose"):
+                    await child.aclose()
+        finally:
+            await super().aclose()
 
     @cached_property
     def feeds(self):

tests/test_async_stream_close.py

@@ -28,6 +28,14 @@ async def test_aclose_closes_chat_client(self):
         await client.aclose()
         assert client.chat.client.is_closed is True
 
+    async def test_aclose_closes_moderation_client(self):
+        client = AsyncStream(api_key="fake", api_secret="fake")
+        _ = client.moderation
+
+        assert client.moderation.client.is_closed is False
+        await client.aclose()
+        assert client.moderation.client.is_closed is True
+
     async def test_aclose_without_child_clients(self):
         """aclose() should work even if video/chat were never accessed."""
         client = AsyncStream(api_key="fake", api_secret="fake")