Skip to content

Commit 07d7ee0

Browse files
authored
Merge pull request #212 from GetStream/fix/fix-blocking-warnings
Fix event loop warnings
2 parents ad91dd9 + 1576178 commit 07d7ee0

2 files changed

Lines changed: 2 additions & 9 deletions

File tree

getstream/video/rtc/audio_track.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -118,8 +118,7 @@ async def write(self, pcm: PcmData):
118118
/ (self.sample_rate * self.channels * self._bytes_per_sample)
119119
) * 1000
120120

121-
# TODO: do not perform logging inside critical section, move this code outside the lock
122-
logger.warning(
121+
logger.debug(
123122
"Audio buffer overflow, dropping %.1fms of audio. Buffer max is %dms",
124123
dropped_ms,
125124
self.audio_buffer_size_ms,
@@ -170,7 +169,6 @@ async def recv(self) -> Frame:
170169

171170
# Calculate samples needed for 20ms frame
172171
samples_per_frame = int(aiortc.mediastreams.AUDIO_PTIME * self.sample_rate)
173-
wakeup_time = 0
174172

175173
# Initialize timestamp if not already done
176174
if self._timestamp is None:
@@ -185,12 +183,7 @@ async def recv(self) -> Frame:
185183
start_ts = self._start or time.time()
186184
wait = start_ts + (self._timestamp / self.sample_rate) - time.time()
187185
if wait > 0:
188-
wakeup_time += time.time() + wait
189186
await asyncio.sleep(wait)
190-
if time.time() - wakeup_time > 0.1:
191-
logger.warning(
192-
f"scheduled sleep took {time.time() - wakeup_time} instead of {wait}, this can happen if there is something blocking the main event-loop, you can enable --debug mode to see blocking traces"
193-
)
194187

195188
self._last_frame_time = time.time()
196189

getstream/video/rtc/network_monitor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ async def _monitor_loop(self):
8787
await asyncio.sleep(self.check_interval)
8888
except asyncio.CancelledError:
8989
self.logger.debug("Network monitoring loop cancelled")
90-
break
90+
raise
9191
except Exception as e:
9292
self.logger.error(
9393
"Error in network monitoring",

0 commit comments

Comments
 (0)