Feedback

[DanForder]

Site Output

• Your colour scheme and font choices help bring some of your personality into the site. Definitely replace with your own images though, it’s your portfolio after all! It doesn’t have to be a photo of you, but something personal to you would be good.
• You’ve used pseudo classes effectively to give the user some feedback on the nav bar, a nice touch. Maybe you could do something similar for the project card buttons?
• I’d recommend using the SVG files for the technical skills/ footer icons. These will scale without blurring and are generally easier to work with.

Responsiveness

• You’ve used a mixture of flex and grid to make your website work across all screen sizes, well done!
• One part to improve could be the projects section, it looks great on mobile, but the projects look quite big on tablet/ small desktop size. Perhaps use a max-width on the project cards to stop them growing larger than you want?

Code Knowledge & Use

• You’ve used some great semantic HTML elements here, using <figure> and <figcaption> for your images is fantastic! And really descriptive alt attributes too.
• When navigating through your website without a mouse, the links at the top should be able to have focus/ be interacted with.. Something to look in to when you get some time
• Your use of @mixin is great to see! Shows you have a genuine curiousity in code and want to push further than the brief/ lessons.

Readability

• All of your code is correctly aligned and indented, your HTML in particular is very well organised with great comments.. a pleasure to read.
• I can see you’ve started using BEM in some sections, the about-me block is a fantastic example, however perhaps about-me__paragraph-one and about-me__paragraph-two could both have a about-me__paragraph class? They have the same styles so should share a class.
• Your project file structure is great, however I’d like to see you split your “block” classes into their own SCSS partial. For example _about-me.scss, _card-block.scss, _header.scss and so on. Get those styles out of style.scss!

Version Control

• I can see you’ve used commits well for this project, with (mostly) meaningful commit messages, keep it up!
• Great to see a [README.md](http://README.md) filled out, this is the first thing that someone will see looking at your code, so it’s important to make a good impression here.