Add Arch test for Aliases and finalize all aliases classes

georgedeploy · georgedeploy · commit 6351a315883e · 2025-12-07T23:28:15.000+01:00
diff --git a/src/Float/Alias/Double.php b/src/Float/Alias/Double.php
@@ -20,6 +20,6 @@
  *
  * @psalm-immutable
  */
-readonly class Double extends FloatStandard
+final readonly class Double extends FloatStandard
 {
 }
diff --git a/src/Float/Alias/FloatType.php b/src/Float/Alias/FloatType.php
@@ -18,6 +18,6 @@
  *
  * @psalm-immutable
  */
-readonly class FloatType extends FloatStandard
+final readonly class FloatType extends FloatStandard
 {
 }
diff --git a/src/Float/Alias/NonNegative.php b/src/Float/Alias/NonNegative.php
@@ -20,6 +20,6 @@
  *
  * @psalm-immutable
  */
-readonly class NonNegative extends FloatNonNegative
+final readonly class NonNegative extends FloatNonNegative
 {
 }
diff --git a/src/Float/Alias/Positive.php b/src/Float/Alias/Positive.php
@@ -20,6 +20,6 @@
  *
  * @psalm-immutable
  */
-readonly class Positive extends FloatPositive
+final readonly class Positive extends FloatPositive
 {
 }
diff --git a/src/Integer/Alias/Id.php b/src/Integer/Alias/Id.php
@@ -21,6 +21,6 @@
  *
  * @psalm-immutable
  */
-readonly class Id extends IntegerPositive
+final readonly class Id extends IntegerPositive
 {
 }
diff --git a/src/Integer/Alias/IntType.php b/src/Integer/Alias/IntType.php
@@ -20,6 +20,6 @@
  *
  * @psalm-immutable
  */
-readonly class IntType extends IntegerStandard
+final readonly class IntType extends IntegerStandard
 {
 }
diff --git a/src/Integer/Alias/Integer.php b/src/Integer/Alias/Integer.php
@@ -20,6 +20,6 @@
  *
  * @psalm-immutable
  */
-readonly class Integer extends IntegerStandard
+final readonly class Integer extends IntegerStandard
 {
 }
diff --git a/src/Integer/Alias/MariaDb/Tiny.php b/src/Integer/Alias/MariaDb/Tiny.php
@@ -20,6 +20,6 @@
  *
  * @psalm-immutable
  */
-readonly class Tiny extends IntegerTiny
+final readonly class Tiny extends IntegerTiny
 {
 }
diff --git a/src/Integer/Alias/NonNegative.php b/src/Integer/Alias/NonNegative.php
@@ -20,6 +20,6 @@
  *
  * @psalm-immutable
  */
-readonly class NonNegative extends IntegerNonNegative
+final readonly class NonNegative extends IntegerNonNegative
 {
 }
diff --git a/src/Integer/Alias/Positive.php b/src/Integer/Alias/Positive.php
@@ -20,6 +20,6 @@
  *
  * @psalm-immutable
  */
-readonly class Positive extends IntegerPositive
+final readonly class Positive extends IntegerPositive
 {
 }
diff --git a/src/Integer/Alias/WeekDay.php b/src/Integer/Alias/WeekDay.php
@@ -9,6 +9,6 @@
 /**
  * @psalm-immutable
  */
-readonly class WeekDay extends IntegerWeekDay
+final readonly class WeekDay extends IntegerWeekDay
 {
 }
diff --git a/src/String/Alias/CountryCode.php b/src/String/Alias/CountryCode.php
@@ -18,6 +18,6 @@
  *
  * @psalm-immutable
  */
-readonly class CountryCode extends StringCountryCode
+final readonly class CountryCode extends StringCountryCode
 {
 }
diff --git a/src/String/Alias/Email.php b/src/String/Alias/Email.php
@@ -18,6 +18,6 @@
  *
  * @psalm-immutable
  */
-readonly class Email extends StringEmail
+final readonly class Email extends StringEmail
 {
 }
diff --git a/src/String/Alias/Json.php b/src/String/Alias/Json.php
@@ -18,6 +18,6 @@
  *
  * @psalm-immutable
  */
-readonly class Json extends StringJson
+final readonly class Json extends StringJson
 {
 }
diff --git a/src/String/Alias/MariaDb/Decimal.php b/src/String/Alias/MariaDb/Decimal.php
@@ -18,6 +18,6 @@
  *
  * @psalm-immutable
  */
-readonly class Decimal extends StringDecimal
+final readonly class Decimal extends StringDecimal
 {
 }
diff --git a/src/String/Alias/MariaDb/Text.php b/src/String/Alias/MariaDb/Text.php
@@ -18,6 +18,6 @@
  *
  * @psalm-immutable
  */
-readonly class Text extends StringText
+final readonly class Text extends StringText
 {
 }
diff --git a/src/String/Alias/MariaDb/VarChar255.php b/src/String/Alias/MariaDb/VarChar255.php
@@ -18,6 +18,6 @@
  *
  * @psalm-immutable
  */
-readonly class VarChar255 extends StringVarChar255
+final readonly class VarChar255 extends StringVarChar255
 {
 }
diff --git a/src/String/Alias/NonBlank.php b/src/String/Alias/NonBlank.php
@@ -18,6 +18,6 @@
  *
  * @psalm-immutable
  */
-readonly class NonBlank extends StringNonBlank
+final readonly class NonBlank extends StringNonBlank
 {
 }
diff --git a/src/String/Alias/NonEmpty.php b/src/String/Alias/NonEmpty.php
@@ -18,6 +18,6 @@
  *
  * @psalm-immutable
  */
-readonly class NonEmpty extends StringNonEmpty
+final readonly class NonEmpty extends StringNonEmpty
 {
 }
diff --git a/src/String/Alias/Str.php b/src/String/Alias/Str.php
@@ -18,6 +18,6 @@
  *
  * @psalm-immutable
  */
-readonly class Str extends StringStandard
+final readonly class Str extends StringStandard
 {
 }
diff --git a/src/String/Alias/StrType.php b/src/String/Alias/StrType.php
@@ -18,6 +18,6 @@
  *
  * @psalm-immutable
  */
-readonly class StrType extends StringStandard
+final readonly class StrType extends StringStandard
 {
 }
diff --git a/src/String/Alias/Url.php b/src/String/Alias/Url.php
@@ -18,6 +18,6 @@
  *
  * @psalm-immutable
  */
-readonly class Url extends StringUrl
+final readonly class Url extends StringUrl
 {
 }
diff --git a/src/String/Alias/Uuid/UuidV4.php b/src/String/Alias/Uuid/UuidV4.php
@@ -18,6 +18,6 @@
  *
  * @psalm-immutable
  */
-readonly class UuidV4 extends StringUuidV4
+final readonly class UuidV4 extends StringUuidV4
 {
 }
diff --git a/src/String/Alias/Uuid/UuidV7.php b/src/String/Alias/Uuid/UuidV7.php
@@ -18,6 +18,6 @@
  *
  * @psalm-immutable
  */
-readonly class UuidV7 extends StringUuidV7
+final readonly class UuidV7 extends StringUuidV7
 {
 }
diff --git a/src/Undefined/Alias/NotExist.php b/src/Undefined/Alias/NotExist.php
@@ -18,6 +18,6 @@
  *
  * @psalm-immutable
  */
-readonly class NotExist extends UndefinedStandard
+final readonly class NotExist extends UndefinedStandard
 {
 }
diff --git a/src/Undefined/Alias/NotFound.php b/src/Undefined/Alias/NotFound.php
@@ -18,6 +18,6 @@
  *
  * @psalm-immutable
  */
-readonly class NotFound extends UndefinedStandard
+final readonly class NotFound extends UndefinedStandard
 {
 }
diff --git a/src/Undefined/Alias/NotSet.php b/src/Undefined/Alias/NotSet.php
@@ -18,6 +18,6 @@
  *
  * @psalm-immutable
  */
-readonly class NotSet extends UndefinedStandard
+final readonly class NotSet extends UndefinedStandard
 {
 }
diff --git a/src/Undefined/Alias/Undefined.php b/src/Undefined/Alias/Undefined.php
@@ -18,6 +18,6 @@
  *
  * @psalm-immutable
  */
-readonly class Undefined extends UndefinedStandard
+final readonly class Undefined extends UndefinedStandard
 {
 }
diff --git a/src/Undefined/Alias/Unknown.php b/src/Undefined/Alias/Unknown.php
@@ -18,6 +18,6 @@
  *
  * @psalm-immutable
  */
-readonly class Unknown extends UndefinedStandard
+final readonly class Unknown extends UndefinedStandard
 {
 }
diff --git a/tests/Arch/Alias.php b/tests/Arch/Alias.php
diff --git a/tests/Arch/AliasTest.php b/tests/Arch/AliasTest.php
@@ -0,0 +1,52 @@
+<?php
+
+declare(strict_types=1);
+
+use PhpTypedValues\Abstract\Bool\BoolType;
+use PhpTypedValues\Abstract\Bool\BoolTypeInterface;
+use PhpTypedValues\Abstract\Float\FloatTypeInterface;
+use PhpTypedValues\Abstract\Integer\IntTypeInterface;
+use PhpTypedValues\Abstract\String\StrTypeInterface;
+use PhpTypedValues\Abstract\TypeInterface;
+use PhpTypedValues\Abstract\Undefined\UndefinedTypeInterface;
+
+arch('Alias Boolean')
+    ->expect('PhpTypedValues\Bool\Alias')
+    ->toBeClasses()
+    ->toBeFinal()
+    ->toExtend(BoolType::class)
+    ->toImplement(TypeInterface::class)
+    ->toImplement(BoolTypeInterface::class)
+    ->toBeReadonly();
+
+arch('Alias Float')
+    ->expect('PhpTypedValues\Float\Alias')
+    ->toBeClasses()
+    ->toBeFinal()
+    ->toImplement(TypeInterface::class)
+    ->toImplement(FloatTypeInterface::class)
+    ->toBeReadonly();
+
+arch('Alias Integer')
+    ->expect('PhpTypedValues\Integer\Alias')
+    ->toBeClasses()
+    ->toBeFinal()
+    ->toImplement(TypeInterface::class)
+    ->toImplement(IntTypeInterface::class)
+    ->toBeReadonly();
+
+arch('Alias String')
+    ->expect('PhpTypedValues\String\Alias')
+    ->toBeClasses()
+    ->toBeFinal()
+    ->toImplement(TypeInterface::class)
+    ->toImplement(StrTypeInterface::class)
+    ->toBeReadonly();
+
+arch('Alias Undefined')
+    ->expect('PhpTypedValues\Undefined\Alias')
+    ->toBeClasses()
+    ->toBeFinal()
+    ->toImplement(TypeInterface::class)
+    ->toImplement(UndefinedTypeInterface::class)
+    ->toBeReadonly();
diff --git a/tests/Arch/HasToStringMethod.php b/tests/Arch/HasToStringMethod.php
diff --git a/tests/Arch/ToStringTest.php b/tests/Arch/ToStringTest.php
@@ -0,0 +1,27 @@
+<?php
+
+declare(strict_types=1);
+
+arch('all VO interfaces declare __toString()')
+    ->expect([
+        'PhpTypedValues\Abstract\Integer\IntTypeInterface.php',
+        'PhpTypedValues\Abstract\Float\FloatTypeInterface.php',
+        'PhpTypedValues\Abstract\String\StrTypeInterface.php',
+        'PhpTypedValues\Abstract\DateTime\DateTimeTypeInterface.php',
+        'PhpTypedValues\Abstract\Bool\BoolTypeInterface.php',
+        'PhpTypedValues\Abstract\Undefined\UndefinedTypeInterface.php',
+    ])
+    ->toBeInterfaces()
+    ->toHaveMethod('__toString');
+
+arch('all value objects have __toString() implementation')
+    ->expect([
+        'PhpTypedValues\Integer\IntType.php',
+        'PhpTypedValues\Float\FloatType.php',
+        'PhpTypedValues\String\StrType.php',
+        'PhpTypedValues\DateTime\DateTimeType.php',
+        'PhpTypedValues\Bool\BoolType.php',
+        'PhpTypedValues\Undefined\UndefinedType.php',
+    ])
+    ->toBeClasses()
+    ->toHaveMethod('__toString');

Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,6 @@`
`20`	`20`	`*`
`21`	`21`	`* @psalm-immutable`
`22`	`22`	`*/`
`23`		`-readonly class Double extends FloatStandard`
	`23`	`+final readonly class Double extends FloatStandard`
`24`	`24`	`{`
`25`	`25`	`}`
Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,6 @@`
`18`	`18`	`*`
`19`	`19`	`* @psalm-immutable`
`20`	`20`	`*/`
`21`		`-readonly class FloatType extends FloatStandard`
	`21`	`+final readonly class FloatType extends FloatStandard`
`22`	`22`	`{`
`23`	`23`	`}`
Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,6 @@`
`21`	`21`	`*`
`22`	`22`	`* @psalm-immutable`
`23`	`23`	`*/`
`24`		`-readonly class Id extends IntegerPositive`
	`24`	`+final readonly class Id extends IntegerPositive`
`25`	`25`	`{`
`26`	`26`	`}`